git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Emanuele Giaquinta <e.giaquinta@glauco.it>, git@vger.kernel.org
Subject: Re: git-cvsimport bug
Date: Wed, 28 Nov 2007 13:55:04 -0500	[thread overview]
Message-ID: <20071128185504.GA11236@coredump.intra.peff.net> (raw)
In-Reply-To: <20071128165746.GC20308@coredump.intra.peff.net>

On Wed, Nov 28, 2007 at 11:57:46AM -0500, Jeff King wrote:

> Some of git-cvsimport is quite old, and it accesses the ref files
> directly. It should be fairly easy to fix; I will post a patch in a few
> minutes.

The patch series is:

  1/3: Add basic cvsimport tests

       We had no tests before, so this at least gives a sanity check. I
       added a t9600 series, though perhaps the cvs-related tests
       (cvsserver and exportcommit) should collapse to a single t9[0-9]*
       series.

  2/3: cvsimport: use show-ref to support packed refs

       This fix is hopefully obvious, and the included test fails
       without it (and this should probably fix Emanuele's problem).

  3/3: cvsimport: miscellaneous packed-ref fixes

       This fixes all of the packed-ref problem spots I could find.
       However, I have no tests that show the problems or that verify
       that the fixes are sane. So apply with caution.

       Probably cvsimport would benefit greatly from a conversion to
       Git.pm, but that is likely to involve a lot of rewriting, and I
       have neither the time nor the inclination for that right now.

-Peff

  reply	other threads:[~2007-11-28 18:56 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-27 15:01 git-cvsimport bug Emanuele Giaquinta
2007-11-28 16:57 ` Jeff King
2007-11-28 18:55   ` Jeff King [this message]
2007-11-28 18:55     ` [PATCH 1/3] Add basic cvsimport tests Jeff King
2007-11-28 22:14       ` Junio C Hamano
2007-11-28 22:20         ` David Kastrup
2007-11-29  9:12         ` Andreas Ericsson
2007-11-28 18:56     ` [PATCH 2/3] cvsimport: use show-ref to support packed refs Jeff King
2007-11-28 19:16       ` Johannes Schindelin
2007-11-28 19:44         ` Jeff King
2007-11-28 20:37           ` Johannes Schindelin
2007-11-28 22:23           ` Junio C Hamano
2007-11-28 22:43             ` Jeff King
2007-11-28 22:52               ` Jeff King
2007-11-28 18:56     ` [PATCH 3/3] cvsimport: miscellaneous packed-ref fixes Jeff King
2007-11-29  0:52       ` Junio C Hamano
2007-11-29 14:19         ` Jeff King
2007-11-30 18:41     ` git-cvsimport bug Emanuele Giaquinta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071128185504.GA11236@coredump.intra.peff.net \
    --to=peff@peff.net \
    --cc=e.giaquinta@glauco.it \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).