From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Anatol Pomozov <anatol.pomozov@gmail.com>,
git@vger.kernel.org, Robin Rosenberg <robin.rosenberg@dewire.com>
Subject: Re: Incorrect git-blame result if I use full path to file
Date: Sun, 2 Dec 2007 21:49:16 -0500 [thread overview]
Message-ID: <20071203024916.GA11003@coredump.intra.peff.net> (raw)
In-Reply-To: <7v4pf0sdp7.fsf@gitster.siamese.dyndns.org>
On Sun, Dec 02, 2007 at 06:40:36PM -0800, Junio C Hamano wrote:
> > Even more useful would be to convert
> > /path/to/repo/file to 'file' internally.
>
> ... that might help "cut & paste from file manager" people, and I think
> we had comment session for such a patch recently on the list.
>
> Sorry, but I lost track of that the current status of that patch. Did
> it die?
I didn't pay attention to it originally, but I assume you mean the
recent patch from Robin Rosenberg (cc'd). Looking it over, I see one
obvious omission: there is no canonicalization of the paths. IOW, I
think it will break in the presence of symlinks (if I specify
/path/to/repo/file, /path/to is a symlink to /other/path, I think the
worktree will end up as /other/path/repo, and fail a string comparison
with /path/to/repo).
-Peff
next prev parent reply other threads:[~2007-12-03 2:49 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-03 0:52 Incorrect git-blame result if I use full path to file Anatol Pomozov
2007-12-03 2:19 ` Junio C Hamano
2007-12-03 2:28 ` Jeff King
2007-12-03 17:26 ` Linus Torvalds
2007-12-03 18:09 ` Johannes Schindelin
2007-12-03 18:13 ` Linus Torvalds
2007-12-03 18:19 ` Linus Torvalds
2007-12-03 2:27 ` Jeff King
2007-12-03 2:40 ` Junio C Hamano
2007-12-03 2:49 ` Jeff King [this message]
2007-12-03 6:55 ` Robin Rosenberg
2007-12-03 20:53 ` [PATCH] Make Git accept absolute path names for files within the work tree Robin Rosenberg
2007-12-03 23:03 ` Junio C Hamano
2007-12-04 1:43 ` Jeff King
2007-12-04 2:17 ` Johannes Schindelin
2007-12-04 6:42 ` Robin Rosenberg
2007-12-04 11:50 ` Johannes Schindelin
2007-12-04 15:59 ` Linus Torvalds
2007-12-04 22:08 ` Jeff King
2007-12-04 22:52 ` Linus Torvalds
2007-12-06 6:12 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071203024916.GA11003@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=anatol.pomozov@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=robin.rosenberg@dewire.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).