From: Alex Riesen <raa.lkml@gmail.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org, Junio C Hamano <junkio@cox.net>
Subject: Re: [PATCH] Simplify crud() in ident.c
Date: Mon, 3 Dec 2007 22:37:02 +0100 [thread overview]
Message-ID: <20071203213702.GD17671@steel.home> (raw)
In-Reply-To: <Pine.LNX.4.64.0712032046480.27959@racer.site>
Johannes Schindelin, Mon, Dec 03, 2007 21:47:09 +0100:
> On Mon, 3 Dec 2007, Alex Riesen wrote:
> > + return c <= 32 ||
> > + c == '.' ||
> > + c == ',' ||
> > + c == ':' ||
> > + c == ';' ||
> > + c == '<' ||
> > + c == '>' ||
> > + c == '"' ||
> > + c == '\'';
>
> Or enhance ctype.c.
>
That's be nice, but the "crud" conflicts with existing classification,
so I'd have to change the is*-macros as well. Don't feel like it.
I believe the code is never in hotpath anyway so the shorter the
better.
next prev parent reply other threads:[~2007-12-03 21:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-03 19:11 [PATCH] Simplify crud() in ident.c Alex Riesen
2007-12-03 20:19 ` Jakub Narebski
2007-12-03 21:32 ` Alex Riesen
2007-12-03 22:55 ` Luke Lu
2007-12-03 20:47 ` Johannes Schindelin
2007-12-03 21:37 ` Alex Riesen [this message]
2007-12-03 22:48 ` Johannes Schindelin
2007-12-03 22:52 ` David Kastrup
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071203213702.GD17671@steel.home \
--to=raa.lkml@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).