From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: gitzilla@gmail.com,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
git@vger.kernel.org
Subject: [PATCH] t9600: require cvsps 2.1 to perform tests
Date: Mon, 3 Dec 2007 20:41:45 -0500 [thread overview]
Message-ID: <20071204014145.GA20145@coredump.intra.peff.net> (raw)
In-Reply-To: <7vir3fe54c.fsf@gitster.siamese.dyndns.org>
git-cvsimport won't run at all with less than cvsps 2.1, because it
lacks the -A flag. But there's no point in preventing people who have an
old cvsps from running the full testsuite.
Tested-by: A Large Angry SCM <gitzilla@gmail.com>
Signed-off-by: Jeff King <peff@peff.net>
---
On Mon, Dec 03, 2007 at 03:21:55PM -0800, Junio C Hamano wrote:
> Jeff, would you want to further amend the patch to use "say" as Hannes
> suggested to make it look nicer?
Here it is.
t/t9600-cvsimport.sh | 20 ++++++++++++++++++--
1 files changed, 18 insertions(+), 2 deletions(-)
diff --git a/t/t9600-cvsimport.sh b/t/t9600-cvsimport.sh
index 08f0f2a..7706430 100755
--- a/t/t9600-cvsimport.sh
+++ b/t/t9600-cvsimport.sh
@@ -3,13 +3,29 @@
test_description='git-cvsimport basic tests'
. ./test-lib.sh
-if ! ( type cvs && type cvsps ) >/dev/null 2>&1
+if ! type cvs >/dev/null 2>&1
then
- test_expect_success 'skipping cvsimport tests, cvs/cvsps not found' ''
+ say 'skipping cvsimport tests, cvs not found'
test_done
exit
fi
+cvsps_version=`cvsps -h 2>&1 | sed -ne 's/cvsps version //p'`
+case "$cvsps_version" in
+2.1)
+ ;;
+'')
+ say 'skipping cvsimport tests, cvsps not found'
+ test_done
+ exit
+ ;;
+*)
+ say 'skipping cvsimport tests, cvsps too old'
+ test_done
+ exit
+ ;;
+esac
+
CVSROOT=$(pwd)/cvsroot
export CVSROOT
# for clean cvsps cache
--
1.5.3.7.2070.g88cf2-dirty
next prev parent reply other threads:[~2007-12-04 1:42 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-02 12:29 make test failure with latest master A Large Angry SCM
2007-12-02 12:52 ` Jakub Narebski
2007-12-02 14:01 ` A Large Angry SCM
2007-12-02 16:34 ` Jeff King
2007-12-02 23:19 ` A Large Angry SCM
2007-12-02 23:41 ` Johannes Schindelin
2007-12-03 1:59 ` Jeff King
2007-12-03 7:33 ` Johannes Sixt
2007-12-03 7:35 ` Jeff King
2007-12-03 23:10 ` A Large Angry SCM
2007-12-03 23:21 ` Junio C Hamano
2007-12-03 23:25 ` A Large Angry SCM
2007-12-04 1:41 ` Jeff King [this message]
2007-12-04 5:37 ` [PATCH] t9600: require cvsps 2.1 to perform tests Junio C Hamano
2007-12-04 15:44 ` Jeff King
2007-12-04 17:39 ` Junio C Hamano
2007-12-05 1:02 ` Jeff King
2007-12-05 5:44 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071204014145.GA20145@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=gitzilla@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).