From: Shawn Bohrer <shawn.bohrer@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Nanako Shiraishi <nanako3@bluebottle.com>, git@vger.kernel.org
Subject: Re: * [BUG] "git clean" does not pay attention to its parameters
Date: Wed, 5 Dec 2007 09:28:16 -0600 [thread overview]
Message-ID: <20071205152816.GA21347@mediacenter.austin.rr.com> (raw)
In-Reply-To: <7veje1zibm.fsf@gitster.siamese.dyndns.org>
On Tue, Dec 04, 2007 at 11:55:41PM -0800, Junio C Hamano wrote:
> Does this patch help? I am not sure why the directory side of the code
> is written that way, but I have a suspicion that "was a directory
> explicitly given as one of the pathspec" check is also bogus, although I
> did not touch that part.
Before the rewrite in C git clean would refuse to remove a directory if
you said:
git clean dir
without using the -d parameter. Per your suggestion this check causes
git clean to remove the directory anyway since you explicitly asked it
to.
next prev parent reply other threads:[~2007-12-05 15:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-05 6:54 [BUG] "git clean" does not pay attention to its parameters Nanako Shiraishi
2007-12-05 7:55 ` Junio C Hamano
2007-12-05 9:49 ` Johannes Schindelin
2007-12-05 10:11 ` * " Junio C Hamano
2007-12-05 10:50 ` Sam Ravnborg
2007-12-05 15:28 ` Shawn Bohrer [this message]
2007-12-06 2:14 ` Junio C Hamano
2007-12-05 18:03 ` Jeff King
2007-12-06 3:28 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071205152816.GA21347@mediacenter.austin.rr.com \
--to=shawn.bohrer@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=nanako3@bluebottle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).