git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Narebski <jnareb@gmail.com>
To: "Blake Ramsdell" <blaker@gmail.com>
Cc: "Wincent Colaiuta" <win@wincent.com>, git@vger.kernel.org
Subject: Re: [PATCH] Silence iconv warnings on Leopard
Date: Fri, 7 Dec 2007 01:11:21 +0100	[thread overview]
Message-ID: <200712070111.23283.jnareb@gmail.com> (raw)
In-Reply-To: <985966520712061504s686395d6jf680363c7b3b9de7@mail.gmail.com>

On Fri, 7 Dec 2007, Blake Ramsdell wrote:
> On Dec 6, 2007 11:07 AM, Wincent Colaiuta <win@wincent.com> wrote:

>> Apple ships a newer version of iconv with Leopard (Mac OS X 10.5/Darwin
>> 9). Ensure that OLD_ICONV is not set on any version of Darwin in the
>> 9.x series; this should be good for at least a couple of years, when
>> Darwin 10 comes out and we can invert the sense of the test to
>> specifically check for Darwin 7 or 8.

>> A more sophisticated and robust check is possible for those who use
>> autoconf, but not everybody does that.
> 
> I did make a patch for configure.ac that does this. If it's
> interesting, I'll send it along.

I would be interested, as I tried to make a patch to configure.ac which
does that. The problem is that it should be check that tests for compile
time _warnings_; my solution was to use '-Werror' flag to make warning
into error, and AC_COMPILE_IFELSE, but this might be gcc only solution.

  Message-ID: <1196895948-25115-1-git-send-email-jnareb@gmail.com>
  http://permalink.gmane.org/gmane.comp.version-control.git/67209

So please send it.

Thanks in advance
-- 
Jakub Narebski
Poland

  reply	other threads:[~2007-12-07  0:08 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-06 19:07 [PATCH] Silence iconv warnings on Leopard Wincent Colaiuta
2007-12-06 23:04 ` Blake Ramsdell
2007-12-07  0:11   ` Jakub Narebski [this message]
2007-12-07  0:12     ` Blake Ramsdell
2007-12-07  0:30     ` Linus Torvalds
2007-12-07  0:41       ` Blake Ramsdell
2007-12-07  0:44         ` Blake Ramsdell
2007-12-07  1:27       ` [PATCH/RFC (take 3)] autoconf: Add test for OLD_ICONV (squelching compiler warning) Jakub Narebski
2007-12-07  7:26         ` Junio C Hamano
2007-12-07  8:25           ` Wincent Colaiuta
2007-12-07  8:22         ` Wincent Colaiuta
2007-12-07  8:29         ` Blake Ramsdell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200712070111.23283.jnareb@gmail.com \
    --to=jnareb@gmail.com \
    --cc=blaker@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=win@wincent.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).