From: Mike Hommey <mh@glandium.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [RFC/PATCH] Add a --nosort option to pack-objects
Date: Fri, 7 Dec 2007 22:46:27 +0100 [thread overview]
Message-ID: <20071207214627.GB13170@glandium.org> (raw)
In-Reply-To: <7v4peu19kr.fsf@gitster.siamese.dyndns.org>
On Fri, Dec 07, 2007 at 01:25:24PM -0800, Junio C Hamano wrote:
> I need to rant here a bit.
>
> Sometimes people say "Here is my patch. If this is accepted, I'll add
> documentation and tests". My reaction is, "Don't you, as the person who
> proposes that change, believe in your patch deeply enough yourself to be
> willing to perfect it, to make it suitable for consumption by the
> general public, whether it is included in my tree or not? A change that
> even you do not believe in deeply enough probably to perfect would not
> benefit the general public, so thanks but no thanks, I'll pass."
As you can seen from my other message, I'm *actually* not sure this is
really material for git as a VCS. I will add documentation unrelated to
--nosort to pack-objects anyways.
Mike
next prev parent reply other threads:[~2007-12-07 21:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-07 21:10 [RFC/PATCH] Add a --nosort option to pack-objects Mike Hommey
2007-12-07 21:24 ` Nicolas Pitre
2007-12-07 21:44 ` Mike Hommey
2007-12-07 21:25 ` Junio C Hamano
2007-12-07 21:37 ` Junio C Hamano
2007-12-07 21:46 ` Mike Hommey [this message]
2007-12-07 22:20 ` Nicolas Pitre
2007-12-08 8:54 ` Mike Hommey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071207214627.GB13170@glandium.org \
--to=mh@glandium.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).