From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christian Couder Subject: [PATCH] git-help: simplify and fix option parsing. Date: Sat, 8 Dec 2007 06:06:27 +0100 Message-ID: <20071208060627.4d89f488.chriscool@tuxfamily.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: git@vger.kernel.org To: Junio Hamano X-From: git-owner@vger.kernel.org Sat Dec 08 06:00:31 2007 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1J0rng-000697-Gr for gcvg-git-2@gmane.org; Sat, 08 Dec 2007 06:00:28 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750823AbXLHFAH (ORCPT ); Sat, 8 Dec 2007 00:00:07 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750963AbXLHFAG (ORCPT ); Sat, 8 Dec 2007 00:00:06 -0500 Received: from smtp1-g19.free.fr ([212.27.42.27]:38629 "EHLO smtp1-g19.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750704AbXLHFAE (ORCPT ); Sat, 8 Dec 2007 00:00:04 -0500 Received: from smtp1-g19.free.fr (localhost.localdomain [127.0.0.1]) by smtp1-g19.free.fr (Postfix) with ESMTP id A8A361AB2AE; Sat, 8 Dec 2007 06:00:02 +0100 (CET) Received: from localhost.boubyland (gre92-7-82-243-130-161.fbx.proxad.net [82.243.130.161]) by smtp1-g19.free.fr (Postfix) with SMTP id 68C0E1AB2B8; Sat, 8 Dec 2007 06:00:02 +0100 (CET) X-Mailer: Sylpheed 2.4.7 (GTK+ 2.12.1; i486-pc-linux-gnu) Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Signed-off-by: Christian Couder --- help.c | 31 +++++++++++-------------------- 1 files changed, 11 insertions(+), 20 deletions(-) Junio wrote about "help.c" in my "git-help: add -w|--web option to display html man page in a browser." patch: > Isn't this "check-help-cmd" duplication ugly, by the way? You are right, this patch should fix it. Thanks. diff --git a/help.c b/help.c index ecc8c66..78686db 100644 --- a/help.c +++ b/help.c @@ -241,7 +241,9 @@ void list_common_cmds_help(void) static const char *cmd_to_page(const char *git_cmd) { - if (!prefixcmp(git_cmd, "git")) + if (!git_cmd) + return "git"; + else if (!prefixcmp(git_cmd, "git")) return git_cmd; else { int page_len = strlen(git_cmd) + 4; @@ -283,38 +285,27 @@ int cmd_version(int argc, const char **argv, const char *prefix) return 0; } -static void check_help_cmd(const char *help_cmd) +int cmd_help(int argc, const char **argv, const char *prefix) { - if (!help_cmd) { + if (argc < 2) { printf("usage: %s\n\n", git_usage_string); list_common_cmds_help(); exit(0); } - else if (!strcmp(help_cmd, "--all") || !strcmp(help_cmd, "-a")) { + const char *help_cmd = argv[1]; + + if (!strcmp(help_cmd, "--all") || !strcmp(help_cmd, "-a")) { printf("usage: %s\n\n", git_usage_string); list_commands(); - exit(0); } -} -int cmd_help(int argc, const char **argv, const char *prefix) -{ - const char *help_cmd = argc > 1 ? argv[1] : NULL; - check_help_cmd(help_cmd); - - if (!strcmp(help_cmd, "--web") || !strcmp(help_cmd, "-w")) { - help_cmd = argc > 2 ? argv[2] : NULL; - check_help_cmd(help_cmd); - - show_html_page(help_cmd); + else if (!strcmp(help_cmd, "--web") || !strcmp(help_cmd, "-w")) { + show_html_page(argc > 2 ? argv[2] : NULL); } else if (!strcmp(help_cmd, "--info") || !strcmp(help_cmd, "-i")) { - help_cmd = argc > 2 ? argv[2] : NULL; - check_help_cmd(help_cmd); - - show_info_page(help_cmd); + show_info_page(argc > 2 ? argv[2] : NULL); } else -- 1.5.3.7.2199.ge1512-dirty