git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mike Hommey <mh@glandium.org>
To: Nicolas Pitre <nico@cam.org>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [RFC/PATCH] Add a --nosort option to pack-objects
Date: Sat, 8 Dec 2007 09:54:29 +0100	[thread overview]
Message-ID: <20071208085429.GB13432@glandium.org> (raw)
In-Reply-To: <alpine.LFD.0.99999.0712071707250.555@xanadu.home>

On Fri, Dec 07, 2007 at 05:20:59PM -0500, Nicolas Pitre wrote:
> On Fri, 7 Dec 2007, Mike Hommey wrote:
> 
> > As you can seen from my other message, I'm *actually* not sure this is
> > really material for git as a VCS. I will add documentation unrelated to
> > --nosort to pack-objects anyways.
> 
> Well, I have serious doubts about this patch in the first place.
> 
> I think it is simply unneeded.
> 
> If you want pack-objects not to change the sort order because you have 
> some sorting of your own, externally implemented, then you simply have 
> to run git-pack-objects feeding it the list of object SHA1s along with a 
> tag of your own which will effectively impose the sorting you want, 
> based on that tag.
> 
> Objects with the same tag will still be sorted amongst themselves which 
> is still a good thing.
> 
> for example, you may have something like:
> 
> 	git rev-list --all --objects |
> 	sed -e 's|foo/logs/.*|LOGS|' |
> 	git pack-objects ...
> 
> This will effectively cluster all foo/logs/* files together for delta 
> compression regardless of their actual name.  Maybe that's what you 
> really want?

I've been thinking about this, but I'm not sure the list won't be
mixed up with the rest of the sort... I'll just try to see what the
sorted list look like...

Mike

      reply	other threads:[~2007-12-08  8:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-07 21:10 [RFC/PATCH] Add a --nosort option to pack-objects Mike Hommey
2007-12-07 21:24 ` Nicolas Pitre
2007-12-07 21:44   ` Mike Hommey
2007-12-07 21:25 ` Junio C Hamano
2007-12-07 21:37   ` Junio C Hamano
2007-12-07 21:46   ` Mike Hommey
2007-12-07 22:20     ` Nicolas Pitre
2007-12-08  8:54       ` Mike Hommey [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071208085429.GB13432@glandium.org \
    --to=mh@glandium.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=nico@cam.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).