From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mike Hommey <mh@glandium.org>
Subject: Re: [PATCH] git-send-email.perl: Really add angle brackets to
	In-Reply-To if necessary
Date: Sun, 9 Dec 2007 19:14:37 +0100
Organization: glandium.org
Message-ID: <20071209181437.GA9211@glandium.org>
References: <1197219900-19334-1-git-send-email-mh@glandium.org> <1197220648-20433-1-git-send-email-mh@glandium.org> <7v63z7rb87.fsf@gitster.siamese.dyndns.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: git@vger.kernel.org, David Kastrup <dak@gnu.org>
To: Junio C Hamano <gitster@pobox.com>
X-From: git-owner@vger.kernel.org Sun Dec 09 19:15:02 2007
Return-path: <git-owner@vger.kernel.org>
Envelope-to: gcvg-git-2@gmane.org
Received: from vger.kernel.org ([209.132.176.167])
	by lo.gmane.org with esmtp (Exim 4.50)
	id 1J1Qg9-00010V-3j
	for gcvg-git-2@gmane.org; Sun, 09 Dec 2007 19:15:01 +0100
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751201AbXLISOk (ORCPT <rfc822;gcvg-git-2@m.gmane.org>);
	Sun, 9 Dec 2007 13:14:40 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751197AbXLISOk
	(ORCPT <rfc822;git-outgoing>); Sun, 9 Dec 2007 13:14:40 -0500
Received: from smtp19.orange.fr ([80.12.242.18]:40849 "EHLO smtp19.orange.fr"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751188AbXLISOj (ORCPT <rfc822;git@vger.kernel.org>);
	Sun, 9 Dec 2007 13:14:39 -0500
Received: from me-wanadoo.net (localhost [127.0.0.1])
	by mwinf1924.orange.fr (SMTP Server) with ESMTP id 8DA161C0009F
	for <git@vger.kernel.org>; Sun,  9 Dec 2007 19:14:38 +0100 (CET)
Received: from namakemono.glandium.org (APuteaux-153-1-79-219.w81-249.abo.wanadoo.fr [81.249.109.219])
	by mwinf1924.orange.fr (SMTP Server) with ESMTP id 6E6D51C0009E;
	Sun,  9 Dec 2007 19:14:38 +0100 (CET)
X-ME-UUID: 20071209181438452.6E6D51C0009E@mwinf1924.orange.fr
Received: from mh by namakemono.glandium.org with local (Exim 4.68)
	(envelope-from <mh@glandium.org>)
	id 1J1Qfm-0002Pi-02; Sun, 09 Dec 2007 19:14:38 +0100
Content-Disposition: inline
In-Reply-To: <7v63z7rb87.fsf@gitster.siamese.dyndns.org>
X-GPG-Fingerprint: A479 A824 265C B2A5 FC54  8D1E DE4B DA2C 54FD 2A58
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: git-owner@vger.kernel.org
Precedence: bulk
List-ID: <git.vger.kernel.org>
X-Mailing-List: git@vger.kernel.org
Archived-At: <http://permalink.gmane.org/gmane.comp.version-control.git/67638>

On Sun, Dec 09, 2007 at 10:09:44AM -0800, Junio C Hamano wrote:
> Mike Hommey <mh@glandium.org> writes:
> >  git-send-email.perl |    5 +++--
> >  1 files changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/git-send-email.perl b/git-send-email.perl
> > index 76baa8e..1434eb2 100755
> > --- a/git-send-email.perl
> > +++ b/git-send-email.perl
> > @@ -367,10 +367,11 @@ if ($thread && !defined $initial_reply_to && $prompting) {
> >  	} while (!defined $_);
> >  
> >  	$initial_reply_to = $_;
> > -	$initial_reply_to =~ s/^\s+<?/</;
> > -	$initial_reply_to =~ s/>?\s+$/>/;
> >  }
> 
> I wonder what the original rationale for these \s+ was.

I'd say copy/paste:
-       $initial_reply_to =~ s/(^\s+|\s+$)//g;
+       $initial_reply_to =~ s/^\s+<?/</;
+       $initial_reply_to =~ s/>?\s+$/>/;

Mike