* [PATCH] Remove .git/branches from the .git template.
@ 2007-12-09 18:38 Kristian Høgsberg
2007-12-09 18:30 ` Junio C Hamano
0 siblings, 1 reply; 3+ messages in thread
From: Kristian Høgsberg @ 2007-12-09 18:38 UTC (permalink / raw)
To: gitster; +Cc: git
The code in git to read the info in .git/branches is still there,
but nothing ever writes to this, so lets stop creating it.
Signed-off-by: Kristian Høgsberg <krh@redhat.com>
---
As far as I can see this should be safe, but I admit to never really
knowing what .git/branches was originally used for - tracking remote
branches or something? In any case, we only ever read from this dir
so the only left in git to deal with this seems to be for compatibilty
with older repos.
Kristian
templates/branches-- | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
delete mode 100644 templates/branches--
diff --git a/templates/branches-- b/templates/branches--
deleted file mode 100644
index fae8870..0000000
--- a/templates/branches--
+++ /dev/null
@@ -1 +0,0 @@
-: this is just to ensure the directory exists.
--
1.5.3.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Remove .git/branches from the .git template.
2007-12-09 18:38 [PATCH] Remove .git/branches from the .git template Kristian Høgsberg
@ 2007-12-09 18:30 ` Junio C Hamano
2007-12-10 4:34 ` Kristian Høgsberg
0 siblings, 1 reply; 3+ messages in thread
From: Junio C Hamano @ 2007-12-09 18:30 UTC (permalink / raw)
To: Kristian Høgsberg; +Cc: git
Kristian Høgsberg <krh@bitplanet.net> writes:
> The code in git to read the info in .git/branches is still there,
> but nothing ever writes to this, so lets stop creating it.
>
> Signed-off-by: Kristian Høgsberg <krh@redhat.com>
> ---
>
> As far as I can see this should be safe, but I admit to never really
> knowing what .git/branches was originally used for - tracking remote
> branches or something? In any case, we only ever read from this dir
> so the only left in git to deal with this seems to be for compatibilty
> with older repos.
This was done purely so that Cogito would not barf on a repository
initialized with "git init" even if it did not bother creating necessary
leading directories when it writes its rough equivalent to .git/remotes/
information. I do not recall if Cogito had such a problem anymore, but
I think it can safely go when Cogito is effectively dead.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Remove .git/branches from the .git template.
2007-12-09 18:30 ` Junio C Hamano
@ 2007-12-10 4:34 ` Kristian Høgsberg
0 siblings, 0 replies; 3+ messages in thread
From: Kristian Høgsberg @ 2007-12-10 4:34 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git
On Sun, Dec 09, 2007 at 10:30:55AM -0800, Junio C Hamano wrote:
> Kristian Høgsberg <krh@bitplanet.net> writes:
>
> > The code in git to read the info in .git/branches is still there,
> > but nothing ever writes to this, so lets stop creating it.
> >
> > Signed-off-by: Kristian Høgsberg <krh@redhat.com>
> > ---
> >
> > As far as I can see this should be safe, but I admit to never really
> > knowing what .git/branches was originally used for - tracking remote
> > branches or something? In any case, we only ever read from this dir
> > so the only left in git to deal with this seems to be for compatibilty
> > with older repos.
>
> This was done purely so that Cogito would not barf on a repository
> initialized with "git init" even if it did not bother creating necessary
> leading directories when it writes its rough equivalent to .git/remotes/
> information. I do not recall if Cogito had such a problem anymore, but
> I think it can safely go when Cogito is effectively dead.
OK, I don't know where cogito is in that respect, I thought maybe we had
just forgotten we still created that directory. Should we just try to
apply the patch to find out how it might interact with cogito?
Kristian
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-12-10 3:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-12-09 18:38 [PATCH] Remove .git/branches from the .git template Kristian Høgsberg
2007-12-09 18:30 ` Junio C Hamano
2007-12-10 4:34 ` Kristian Høgsberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).