From: Mike Hommey <mh@glandium.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: Andreas Ericsson <ae@op5.se>, git@vger.kernel.org
Subject: Re: [PATCH 2/2] Add support for URLs to git-apply
Date: Mon, 10 Dec 2007 07:46:59 +0100 [thread overview]
Message-ID: <20071210064659.GA4148@glandium.org> (raw)
In-Reply-To: <7vhciro4vx.fsf@gitster.siamese.dyndns.org>
On Sun, Dec 09, 2007 at 02:54:58PM -0800, Junio C Hamano wrote:
> Andreas Ericsson <ae@op5.se> writes:
>
> > Mike Hommey wrote:
> >> Instead of doing several "wget -O - url | git-apply -" in a raw, you now
> >> can just git-apply url1 url2 ...
> >>
> >
> > I seriously like this idea. Combined with gitweb (or cgit), it could be
> > used as a cherry-pick from someone else's repo :)
>
> FWIW, my initial impression is that I seriously dislike this. It may be
> good if the patch were to git-am, but when git-apply rejects an
> inapplicable patch, there won't be nothing left for you to recover with
> and you need to re-download the patch anyway.
There are some usecase differences between git-apply and git-am.
Probably, this change would be good to have on both.
Mike
next prev parent reply other threads:[~2007-12-10 6:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-09 10:04 [PATCH 1/2] Move the file read logic to read_patch_file() in builtin-apply.c Mike Hommey
2007-12-09 10:04 ` [PATCH 2/2] Add support for URLs to git-apply Mike Hommey
2007-12-09 17:02 ` Mike Hommey
2007-12-09 21:04 ` Andreas Ericsson
2007-12-09 22:54 ` Junio C Hamano
2007-12-10 6:46 ` Mike Hommey [this message]
2007-12-10 11:16 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071210064659.GA4148@glandium.org \
--to=mh@glandium.org \
--cc=ae@op5.se \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).