From: Charles Bailey <charles@hashpling.org>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Fix clone not to ignore depth when performing a local clone
Date: Tue, 11 Dec 2007 18:26:03 +0000 [thread overview]
Message-ID: <20071211182603.GA4063@hashpling.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0712111154070.27959@racer.site>
On Tue, Dec 11, 2007 at 11:54:54AM +0000, Johannes Schindelin wrote:
> Hi,
>
> On Tue, 11 Dec 2007, Charles Bailey wrote:
>
> > @@ -205,7 +205,10 @@ fi
> > # it is local
> > if base=$(get_repo_base "$repo"); then
> > repo="$base"
> > - local=yes
> > + if test -z "$depth"
> > + then
> > + local=yes
> > + fi
> > fi
>
> Or shorter:
>
> - local=yes
> + test -z "$depth" && local=yes
>
> Ciao,
> Dscho
>
Yes, I have no particular preference. I was just following the
'convention' of the -z "$origin" test a few lines above although
I could see uses of both alternatives as well as instances of [...]
instead of test ... .
Charles.
prev parent reply other threads:[~2007-12-11 18:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-11 6:47 [PATCH] Fix clone not to ignore depth when performing a local clone Charles Bailey
2007-12-11 11:54 ` Johannes Schindelin
2007-12-11 18:26 ` Charles Bailey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071211182603.GA4063@hashpling.org \
--to=charles@hashpling.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).