From: Alex Riesen <raa.lkml@gmail.com>
To: Nicolas Pitre <nico@cam.org>
Cc: git@vger.kernel.org
Subject: Re: 'git fast-export' is crashing on the gcc repo
Date: Wed, 12 Dec 2007 02:38:28 +0100 [thread overview]
Message-ID: <20071212013828.GC19857@steel.home> (raw)
In-Reply-To: <alpine.LFD.0.99999.0712111703380.555@xanadu.home>
Nicolas Pitre, Tue, Dec 11, 2007 23:06:42 +0100:
>
> Well, ignore the above. It seems that most of stdio doesn't set errno
> so the above is crap.
>
Well, it had no reason to in this case. It's not an error.
It does not even have to do a syscall.
> diff --git a/builtin-fast-export.c b/builtin-fast-export.c
> index 2136aad..c32a124 100755
> --- a/builtin-fast-export.c
> +++ b/builtin-fast-export.c
> @@ -103,7 +103,7 @@ static void handle_object(const unsigned char *sha1)
> mark_object(object);
>
> printf("blob\nmark :%d\ndata %lu\n", last_idnum, size);
> - if (fwrite(buf, size, 1, stdout) != 1)
> + if (fwrite(buf, 1, size, stdout) != size)
That's a probable syscall which could be spared
next prev parent reply other threads:[~2007-12-12 1:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-11 20:27 'git fast-export' is crashing on the gcc repo Nicolas Pitre
2007-12-11 20:35 ` Marco Costalba
2007-12-11 22:01 ` [PATCH] Fix git-fast-export for zero-sized blobs Alex Riesen
2007-12-11 22:20 ` Nicolas Pitre
2007-12-11 22:06 ` 'git fast-export' is crashing on the gcc repo Nicolas Pitre
2007-12-12 1:38 ` Alex Riesen [this message]
2007-12-12 1:45 ` Nicolas Pitre
2007-12-12 8:32 ` Junio C Hamano
2007-12-12 8:46 ` David Kastrup
2007-12-12 8:56 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071212013828.GC19857@steel.home \
--to=raa.lkml@gmail.com \
--cc=git@vger.kernel.org \
--cc=nico@cam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).