git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* exit with error for "git remote update"
@ 2007-12-12  6:17 Robert Schiele
  0 siblings, 0 replies; only message in thread
From: Robert Schiele @ 2007-12-12  6:17 UTC (permalink / raw)
  To: Theodore Ts'o; +Cc: git

[-- Attachment #1: Type: text/plain, Size: 943 bytes --]

Hi,

When I call "git remote update" without an additional parameter it always
returns with an error, even when all fetch commands processed without a
problem.

This is because of the exit(1) in the following code:

elsif ($ARGV[0] eq 'update') {
        if (@ARGV <= 1) {
                update_remote("default");
                exit(1);
        }
        for ($i = 1; $i < @ARGV; $i++) {
                update_remote($ARGV[$i]);
        }
}

Shouldn't this exit(1) be an exit(0) instead or just rewrite this part of the
code as

elsif ($ARGV[0] eq 'update') {
        if (@ARGV <= 1) {
                update_remote("default");
        } else {
                for ($i = 1; $i < @ARGV; $i++) {
                        update_remote($ARGV[$i]);
                }
        }
}

Robert

-- 
Robert Schiele
Dipl.-Wirtsch.informatiker	mailto:rschiele@gmail.com

"Quidquid latine dictum sit, altum sonatur."

[-- Attachment #2: Type: application/pgp-signature, Size: 194 bytes --]

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2007-12-12  6:17 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-12-12  6:17 exit with error for "git remote update" Robert Schiele

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).