From: Jeff King <peff@peff.net>
To: Martin Langhoff <martin.langhoff@gmail.com>
Cc: Markus Klinik <markus.klinik@gmx.de>, git@vger.kernel.org
Subject: Re: git-cvsexportcommit fails for huge commits
Date: Wed, 12 Dec 2007 23:17:37 -0500 [thread overview]
Message-ID: <20071213041737.GA23624@coredump.intra.peff.net> (raw)
In-Reply-To: <46a038f90712121158n674a9044t75ef99473314457c@mail.gmail.com>
On Thu, Dec 13, 2007 at 08:58:33AM +1300, Martin Langhoff wrote:
> IOWs, the protocol *is* atomic, and this patch does make things
> slightly more brittle. Perhaps require an option to be set before we
> do this?
I started writing a patch to let the user specify the limit, but it was
just too ugly. What user knows the right limit? We are probably better
off just setting the limit at something high and reasonable (like 64K --
it would be nice to get feedback from Markus on what platform he is
using and what is a reasonable value), or just using a tempfile with
xargs, which should figure out the correct value.
-Peff
next prev parent reply other threads:[~2007-12-13 4:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-11 20:04 git-cvsexportcommit fails for huge commits Markus Klinik
2007-12-12 8:31 ` Jeff King
2007-12-12 9:21 ` Junio C Hamano
2007-12-12 9:25 ` Jeff King
2007-12-14 3:22 ` Junio C Hamano
2007-12-14 4:45 ` Jeff King
2007-12-14 9:15 ` Jeff King
2007-12-14 13:47 ` Robin Rosenberg
2007-12-15 10:09 ` Jeff King
2007-12-12 16:02 ` Linus Torvalds
2007-12-12 16:17 ` Jeff King
2007-12-12 19:58 ` Martin Langhoff
2007-12-13 4:17 ` Jeff King [this message]
2007-12-13 8:39 ` Markus Klinik
2007-12-13 9:01 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071213041737.GA23624@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=markus.klinik@gmx.de \
--cc=martin.langhoff@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).