From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Markus Klinik <markus.klinik@gmx.de>, git@vger.kernel.org
Subject: Re: git-cvsexportcommit fails for huge commits
Date: Thu, 13 Dec 2007 23:45:54 -0500 [thread overview]
Message-ID: <20071214044554.GB10169@sigill.intra.peff.net> (raw)
In-Reply-To: <7vzlwevu2k.fsf@gitster.siamese.dyndns.org>
On Thu, Dec 13, 2007 at 07:22:43PM -0800, Junio C Hamano wrote:
> Sorry, you are right.
>
> Perhaps pick a reasonably small but not insanely small value, like 16kB,
> forget about the atomicity issues for now, as an interim improvement
> patch?
I'm fine with that. We can probably go a bit higher than that. From my
limited testing[1]:
Linux 2.6.18: ~128K
Linux 2.6.23: huge? I tried ~350K and it worked fine
Solaris: huge? I tried ~350K and it worked fine
Freebsd 6.1: ~256K
So it seems that we could probably go with something more like 64K, and
then only truly pathological cases should trigger the behavior.
-Peff
[1] All numbers are approximate and determined experimentally with
something like:
for i in `seq 1 $n`; do
touch $long_filename-$i
done
ls * | wc
next prev parent reply other threads:[~2007-12-14 4:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-11 20:04 git-cvsexportcommit fails for huge commits Markus Klinik
2007-12-12 8:31 ` Jeff King
2007-12-12 9:21 ` Junio C Hamano
2007-12-12 9:25 ` Jeff King
2007-12-14 3:22 ` Junio C Hamano
2007-12-14 4:45 ` Jeff King [this message]
2007-12-14 9:15 ` Jeff King
2007-12-14 13:47 ` Robin Rosenberg
2007-12-15 10:09 ` Jeff King
2007-12-12 16:02 ` Linus Torvalds
2007-12-12 16:17 ` Jeff King
2007-12-12 19:58 ` Martin Langhoff
2007-12-13 4:17 ` Jeff King
2007-12-13 8:39 ` Markus Klinik
2007-12-13 9:01 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071214044554.GB10169@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=markus.klinik@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).