From: Johannes Sixt <johannes.sixt@telecom.at>
To: "Kristian Høgsberg" <krh@redhat.com>,
git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH 1/2] Fix config lockfile handling.
Date: Fri, 14 Dec 2007 20:32:15 +0100 [thread overview]
Message-ID: <20071214193216.13C795A873@dx.sixt.local> (raw)
In-Reply-To: 1197660157-24109-2-git-send-email-krh@redhat.com
Kristian Høgsberg wrote:
> When we commit or roll back the lock file the fd is automatically closed,
> so don't do that again. Also, just keep the lock on the stack.
IIRC, locks are accessed from atexit(), e.g. during a die(). So you must not
put one on the stack.
-- Hannes
prev parent reply other threads:[~2007-12-14 19:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-14 19:22 config.c fixes Kristian Høgsberg
2007-12-14 19:22 ` [PATCH 1/2] Fix config lockfile handling Kristian Høgsberg
2007-12-14 19:22 ` [PATCH 2/2] Use a strbuf for building up section header and key/value pair strings Kristian Høgsberg
2007-12-14 19:29 ` [PATCH 1/2] Fix config lockfile handling Johannes Schindelin
2007-12-14 20:07 ` Junio C Hamano
2007-12-14 20:15 ` Johannes Schindelin
2007-12-14 21:18 ` Junio C Hamano
2007-12-14 19:32 ` Johannes Sixt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071214193216.13C795A873@dx.sixt.local \
--to=johannes.sixt@telecom.at \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=krh@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).