git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>, git@vger.kernel.org
Subject: trim_common_tail bug?
Date: Sat, 15 Dec 2007 06:16:22 -0500	[thread overview]
Message-ID: <20071215111621.GA8139@coredump.intra.peff.net> (raw)

Something seems to be not quite right with the trim_common_tail code in
xdiff-interface.c. The diff I just sent for contrib/completion looks
fine (as I sent it) when I comment out trim_common_tail. But using
the current master, it looks like this:

diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index 58e0e53..2fd32db 100755
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -291,7 +291,7 @@ __git_commands ()
 	for i in $(git help -a|egrep '^ ')
 	do
 		case $i in
-		add--interactive) : plumbing;;
+		*--*)             : plumbing pattern;;
 		applymbox)        : ask gittus;;
 		applypatch)       : ask gittus;;
 		archimport)       : import;;
@@ -307,5 +307,4 @@ __git_commands ()
 		diff-index)       : plumbing;;
 		diff-tree)        : plumbing;;
 		fast-import)      : import;;
-		fsck-objects)     : plumbing;;
-		fetch--tool)      : plumbing;;
\ No newline at end of file
+		fsck-objects)     : plumbing;;
\ No newline at end of file

-Peff

             reply	other threads:[~2007-12-15 11:16 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-15 11:16 Jeff King [this message]
2007-12-15 15:51 ` trim_common_tail bug? Jeff King
2007-12-15 17:49   ` Junio C Hamano
2007-12-15 20:02     ` Jeff King
2007-12-16  7:06       ` Jeff King
2007-12-16 19:43         ` Junio C Hamano
2007-12-16 21:16           ` Junio C Hamano
2007-12-16 21:21             ` Jeff King
2007-12-16 21:49               ` [PATCH] Re-re-re-fix common tail optimization Junio C Hamano
2007-12-16 22:15                 ` Jeff King
2007-12-16 22:23                   ` Junio C Hamano
2007-12-16 22:28                     ` Junio C Hamano
2007-12-16 22:29                     ` Jeff King
2007-12-17  8:42                       ` Wincent Colaiuta
2007-12-17 10:39                         ` Johannes Schindelin
2007-12-17 10:59                           ` Wincent Colaiuta
2007-12-17 11:57                             ` Johannes Schindelin
2007-12-17 12:08                               ` Wincent Colaiuta
2007-12-17 12:12                                 ` Jeff King
2007-12-17 12:20                                 ` Johannes Sixt
2007-12-17 12:51                                   ` Johannes Schindelin
2007-12-17 17:58                                     ` Junio C Hamano
2007-12-17 18:05                                       ` Johannes Schindelin
2007-12-19 14:18                 ` Charles Bailey
2007-12-19 14:27                   ` Jeff King
2007-12-19 14:37                     ` Charles Bailey
2007-12-20  0:21                       ` Junio C Hamano
2007-12-20  1:38                         ` Wincent Colaiuta
2007-12-20  9:23                         ` Charles Bailey
2007-12-20  9:40                           ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071215111621.GA8139@coredump.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).