From: Jeff King <peff@peff.net>
To: Wincent Colaiuta <win@wincent.com>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Junio C Hamano <gitster@pobox.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
git@vger.kernel.org
Subject: Re: [PATCH] Re-re-re-fix common tail optimization
Date: Mon, 17 Dec 2007 07:12:10 -0500 [thread overview]
Message-ID: <20071217121209.GA15368@coredump.intra.peff.net> (raw)
In-Reply-To: <57245FA1-361B-4333-B490-A2CC99ED4F9C@wincent.com>
On Mon, Dec 17, 2007 at 01:08:45PM +0100, Wincent Colaiuta wrote:
>> So yeah, the second "diff" cannot be "git diff". Maybe "cmp", but not
>> "git diff".
>
> Well cmp would be fine as well, seeing all we want is a boolean "is this the
> same or not" answer. (I'm not familiar with the GNU diff bug you speak of,
> but was it so bad that it couldn't even get *that* answer right?)
Personally I find it useful to generate the diff output when viewing
with "-v". But if there is a real reason to use cmp over diff in the
script, one can always manually go into the trash directory and run
diff.
-Peff
next prev parent reply other threads:[~2007-12-17 12:12 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-15 11:16 trim_common_tail bug? Jeff King
2007-12-15 15:51 ` Jeff King
2007-12-15 17:49 ` Junio C Hamano
2007-12-15 20:02 ` Jeff King
2007-12-16 7:06 ` Jeff King
2007-12-16 19:43 ` Junio C Hamano
2007-12-16 21:16 ` Junio C Hamano
2007-12-16 21:21 ` Jeff King
2007-12-16 21:49 ` [PATCH] Re-re-re-fix common tail optimization Junio C Hamano
2007-12-16 22:15 ` Jeff King
2007-12-16 22:23 ` Junio C Hamano
2007-12-16 22:28 ` Junio C Hamano
2007-12-16 22:29 ` Jeff King
2007-12-17 8:42 ` Wincent Colaiuta
2007-12-17 10:39 ` Johannes Schindelin
2007-12-17 10:59 ` Wincent Colaiuta
2007-12-17 11:57 ` Johannes Schindelin
2007-12-17 12:08 ` Wincent Colaiuta
2007-12-17 12:12 ` Jeff King [this message]
2007-12-17 12:20 ` Johannes Sixt
2007-12-17 12:51 ` Johannes Schindelin
2007-12-17 17:58 ` Junio C Hamano
2007-12-17 18:05 ` Johannes Schindelin
2007-12-19 14:18 ` Charles Bailey
2007-12-19 14:27 ` Jeff King
2007-12-19 14:37 ` Charles Bailey
2007-12-20 0:21 ` Junio C Hamano
2007-12-20 1:38 ` Wincent Colaiuta
2007-12-20 9:23 ` Charles Bailey
2007-12-20 9:40 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071217121209.GA15368@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=torvalds@linux-foundation.org \
--cc=win@wincent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).