Re: The Reposithon! Take 2 [URL FIX]

Re: The Reposithon! Take 2 [URL FIX]

[Sam Vilain]

Nicholas Clark wrote:
> On Tue, Dec 18, 2007 at 12:48:26AM +1300, Sam Vilain wrote:
>> Nicholas Clark wrote:
>>> error: Could not interpret The page was, like, not found and stuff. as something to pull
>>>
>>>
>>>                            ^ random capitalisation or missing punctuation
>>>                                          ^ slang interjection
>>>                                                          ^ slang interjection
>>>                                                                     ^ missing capitalisation
>>>
>> I've never had my server 404 message
>>
>>   http://utsl.gen.nz/err/404.html
>>
>> So well critiqued!  Thanks!  :-)
>>
>> Hopefully all the pull problems should be sorted now.
> 
> I remain unhappy that git does not tell me that it's reporting a 404 error.
> 404 makes sense in any language. What the server admin chooses as the
> accompanying page may well not, although usually it would be because he or
> she chooses to make it report errors in the local language.

meh.  look, actually tell you what my little web server is returning the
wrong error HTTP response code.  Which is a pretty stupid
misconfiguration and not one you'd see very often.  So the data gets a
little further in before it is noticed to be wrong.

The error message isn't the best, no.

Junio, any chance of this going in?

Subject: Clarify error response from 'git fetch' for bad responses

This error message prints the reponse from the server at this point.
Label it as such in the output.
---
 walker.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/walker.c b/walker.c
index 397b80d..adc3e80 100644
--- a/walker.c
+++ b/walker.c
@@ -274,7 +274,7 @@ int walker_fetch(struct walker *walker, int targets, char **target,
 
 	for (i = 0; i < targets; i++) {
 		if (interpret_target(walker, target[i], &sha1[20 * i])) {
-			error("Could not interpret %s as something to pull", target[i]);
+			error("Could not interpret response from server '%s' as something to pull", target[i]);
 			goto unlock_and_fail;
 		}
 		if (process(walker, lookup_unknown_object(&sha1[20 * i])))

Re: The Reposithon! Take 2 [URL FIX]

[Junio C Hamano]

Sam Vilain <sam@vilain.net> writes:

> The error message isn't the best, no.
>
> Junio, any chance of this going in?

Looks innocuous and an obvious improvement to me.

Re: The Reposithon! Take 2 [URL FIX]

[Nicholas Clark]

On Mon, Dec 17, 2007 at 10:00:57AM -0800, Junio C Hamano wrote:
> Sam Vilain <sam@vilain.net> writes:
> 
> > The error message isn't the best, no.
> >
> > Junio, any chance of this going in?
> 
> Looks innocuous and an obvious improvement to me.

Cool. Thanks to you both for addressing this concern of mine so rapidly.

Nicholas Clark