From: Luciano Rocha <luciano@eurotux.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2] builtin-tag.c: allow arguments in $EDITOR
Date: Thu, 20 Dec 2007 12:06:01 +0000 [thread overview]
Message-ID: <20071220120601.GA15290@bit.office.eurotux.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0712201255510.14355@wbgn129.biozentrum.uni-wuerzburg.de>
[-- Attachment #1: Type: text/plain, Size: 731 bytes --]
On Thu, Dec 20, 2007 at 12:58:59PM +0100, Johannes Schindelin wrote:
> Hi,
>
> On Thu, 20 Dec 2007, Luciano Rocha wrote:
>
> > The previous sh version of git-commit evaluated the value of the defined
> > editor, thus allowing arguments.
> >
> > Make the builtin version work the same, by adding an explicit check for
> > arguments in the editor command, and extract them to an additional
> > argument.
>
> Anything wrong with that patch?
>
> http://article.gmane.org/gmane.comp.version-control.git/68444
No, I just missed it in the mailing list. That patch also supports any
number of whitespace/arguments.
--
Luciano Rocha <luciano@eurotux.com>
Eurotux Informática, S.A. <http://www.eurotux.com/>
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2007-12-20 12:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-19 23:23 [PATCH] builtin-tag.c: allow arguments in $EDITOR Luciano Rocha
2007-12-20 9:57 ` [PATCH v2] " Luciano Rocha
2007-12-20 11:58 ` Johannes Schindelin
2007-12-20 12:06 ` Luciano Rocha [this message]
2007-12-20 22:14 ` Junio C Hamano
2007-12-21 0:33 ` Steven Grimm
2007-12-22 14:50 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071220120601.GA15290@bit.office.eurotux.com \
--to=luciano@eurotux.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).