From: Joel Becker <Joel.Becker@oracle.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: David Brown <git@davidb.org>, git@vger.kernel.org
Subject: Re: [PATCH] git-send-email: Add --suppress-all-from option.
Date: Fri, 21 Dec 2007 11:21:20 -0800 [thread overview]
Message-ID: <20071221192120.GA13171@mail.oracle.com> (raw)
In-Reply-To: <7vfxxw7xkb.fsf@gitster.siamese.dyndns.org>
On Fri, Dec 21, 2007 at 09:43:48AM -0800, Junio C Hamano wrote:
> The option name feels as if it is somehow affecting From: but
> this is all about recipients. It needs to be named better.
>
> Even more importantly, git-send-email has too many places that
> pick up additional recipients. I doubt --suppress-foo to
> suppress one such source "foo" is sustainable. We should try to
> clean up the mess, not adding to it.
Yay, even better that we're going to evaluate the sucker (I was
just complaining about this yesterday to someone, so how apropos that it
comes up on-list).
First and foremost, I think git-send-email should not default to
anything. It was quite a surprise, the first time I tried to use it, to
discover I had to add two options to ~/.gitconfig just for sane
behavior. Never mind that I couldn't suppress the author-cc. I think
that a naive "git send-email --to bob@bob.com foo.patch" should only go
to bob, period.
We can then add ways to auto-cc. I don't mind typing the extra
bits. Heck, we could even define a --review that does what is currently
the default - cc-everyone-who-might-care-as-we-go-upstream.
Joel
--
Life's Little Instruction Book #99
"Think big thoughts, but relish small pleasures."
Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker@oracle.com
Phone: (650) 506-8127
next prev parent reply other threads:[~2007-12-21 19:23 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-21 6:01 [PATCH] git-send-email: Add --suppress-all-from option David Brown
2007-12-21 11:05 ` Joel Becker
2007-12-21 11:14 ` Brian Swetland
2007-12-21 17:43 ` Junio C Hamano
2007-12-21 19:21 ` Joel Becker [this message]
2007-12-22 0:55 ` Theodore Tso
2007-12-21 22:37 ` David Brown
2007-12-24 19:01 ` [PATCH] git-send-email: Generalize auto-cc recipient mechanism David Brown
2007-12-24 21:03 ` Joel Becker
2007-12-24 21:26 ` [PATCH] git-send-email: Add --suppress-cc all David Brown
2007-12-24 21:59 ` Joel Becker
2007-12-24 21:36 ` [PATCH] git-send-email: Generalize auto-cc recipient mechanism David Brown
2007-12-25 21:04 ` Junio C Hamano
2007-12-26 3:39 ` David Brown
2007-12-26 3:56 ` David Brown
2007-12-26 4:54 ` Sean
2007-12-26 5:32 ` David Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071221192120.GA13171@mail.oracle.com \
--to=joel.becker@oracle.com \
--cc=git@davidb.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).