From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Jon Hancock <redstarling@gmail.com>,
git@vger.kernel.org
Subject: Re: rm and mv commands: should I use them?
Date: Sun, 6 Jan 2008 22:06:42 -0500 [thread overview]
Message-ID: <20080107030642.GA18194@coredump.intra.peff.net> (raw)
In-Reply-To: <7v63y62xwj.fsf@gitster.siamese.dyndns.org>
On Sun, Jan 06, 2008 at 06:05:16PM -0800, Junio C Hamano wrote:
> Actually, I think I found a bug.
>
> $ git reset --hard
> $ echo >>Makefile
> $ git diff --numstat
> 1 0 Makefile
> $ git mv Makefile makefile
> $ git diff
> $ git diff --cached -M --numstat
> 1 0 Makefile => makefile
>
> "git mv" should not have staged the change. It should have
> moved the index entry from Makefile to makefile and moved the
> work tree files.
I thought there was some discussion about this a few months ago,
concerning what exactly it should do, and that was how we arrived at the
current behavior. However, I can't seem to find it now. Maybe I dreamed
it.
-Peff
next prev parent reply other threads:[~2008-01-07 3:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-06 7:55 rm and mv commands: should I use them? Jon Hancock
2008-01-06 8:04 ` David Brown
2008-01-06 8:08 ` Brian Swetland
2008-01-06 8:08 ` Jeff King
2008-01-06 19:22 ` Linus Torvalds
2008-01-07 1:55 ` Jeff King
2008-01-07 2:05 ` Junio C Hamano
2008-01-07 3:06 ` Jeff King [this message]
2008-01-07 18:37 ` Robin Rosenberg
2008-01-07 3:05 ` Jay Soffian
2008-01-07 5:01 ` David Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080107030642.GA18194@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=redstarling@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).