git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Robin Rosenberg <robin.rosenberg.lists@dewire.com>
To: "Roger C. Soares" <rogersoares@intelinet.com.br>
Cc: git@vger.kernel.org, "Shawn O. Pearce" <spearce@spearce.org>
Subject: Re: [EGIT PATCH] Showing commit info like the CVS plugin instead of tooltips.
Date: Tue, 8 Jan 2008 23:20:52 +0100	[thread overview]
Message-ID: <200801082320.52548.robin.rosenberg.lists@dewire.com> (raw)
In-Reply-To: <200801072320.26987.rogersoares@intelinet.com.br>

tisdagen den 8 januari 2008 skrev du:
> Tooltips for the info were annoying, especially on MacOS where the tooltip center is your pointer location.
> It is now possible to copy&paste data.
> Like the CVS plugin, there's a menu to show/hide views. Thought it doesn't save in the preferences store for now.
Looks nice. We probably want this into preferences and I'd still like the tooltop as an option. I.e. when you turn off
the other panes the tooltip should come back. What I'd really want is the "Press F2"-version, like the javadoc
tooltips, but that requires some more work (I guess, maybe only a little is needed).

> +	/* private */TextViewer revDetailTextViewer;
> +	/* private */TextViewer revCommentTextViewer;
> +	/* private */IAction toggleCommentWrapAction;
> +	/* private */IAction toggleRevDetailAction;
> +	/* private */IAction toggleRevCommentAction;
>  
> -	private Table table;
> +	/* private */Table table;
>  
> -	private List<IFileRevision> fileRevisions;
> +	/* private */List<IFileRevision> fileRevisions;
>  
> -	protected boolean hintShowDiffNow;
> +	/* private */boolean hintShowDiffNow;
Why? What's wrong plain private?

> \ No newline at end of file
There was trailing whitespace also, but I can fix such things easily. I'm erasing those on changed lines only, a
change at the time at the moment instead of big ws fixes. In eclipse 3.3 there is an option to fix trailing spaces
on save on changed lines only.

-- robin

  reply	other threads:[~2008-01-08 22:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-08  1:20 [EGIT PATCH] Showing commit info like the CVS plugin instead of tooltips Roger C. Soares
2008-01-08 22:20 ` Robin Rosenberg [this message]
2008-01-09  1:17   ` Roger C. Soares
2008-01-09 18:12     ` Robin Rosenberg
2008-01-10  0:17       ` Roger C. Soares

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200801082320.52548.robin.rosenberg.lists@dewire.com \
    --to=robin.rosenberg.lists@dewire.com \
    --cc=git@vger.kernel.org \
    --cc=rogersoares@intelinet.com.br \
    --cc=spearce@spearce.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).