From: Robin Rosenberg <robin.rosenberg.lists@dewire.com>
To: "Roger C. Soares" <rogersoares@intelinet.com.br>
Cc: git@vger.kernel.org, "Shawn O. Pearce" <spearce@spearce.org>
Subject: Re: [EGIT PATCH] Showing abbreviated commit hash of the versions in Compare editor.
Date: Fri, 11 Jan 2008 00:46:40 +0100 [thread overview]
Message-ID: <200801110046.41786.robin.rosenberg.lists@dewire.com> (raw)
In-Reply-To: <4784247B.10604@intelinet.com.br>
onsdagen den 9 januari 2008 skrev Roger C. Soares:
> Robin Rosenberg escreveu:
> > I'm implementing fetch (with some help from Shawn). Progress in
> > place. I still need to update refs and get in consistent with native
> > git behaviour.
> >
> > I'm also updating the javadocs.
> Cool.
>
> I use a lot the eclipse feature that highlights all occurences of a
> variable or method but with all the warnings in the project it is
> difficult to visually find these occurences. So I'm anxious to remove a
> lot of warnings. Public methods without documentation are one of them.
> Is it ok if I send you a patch removing all the warnings I know how but
> the ones about public methods needing documentation as you're already
> documenting them? I also want to remove the auto generated TODOs, as
> they don't actually say what to do, like this one:
> // TODO Auto-generated catch block
I pushed my doc-branch as pu, you can look at it. My intention is take a look again
and then push it as master if there are no objections. Is it ok and good to flags
public stuff without javadoc as an error (tip pu commit)?
The abbr commit patch is already pushed to master.
-- robin
next prev parent reply other threads:[~2008-01-10 23:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-08 1:15 [EGIT PATCH] Showing abbreviated commit hash of the versions in Compare editor Roger C. Soares
2008-01-08 22:12 ` Robin Rosenberg
2008-01-09 1:33 ` Roger C. Soares
2008-01-10 23:46 ` Robin Rosenberg [this message]
2008-01-12 3:02 ` Roger C. Soares
2008-01-12 3:37 ` Roger C. Soares
2008-01-12 15:44 ` Robin Rosenberg
2008-01-13 21:02 ` Roger C. Soares
2008-01-13 23:54 ` javadoc (was [EGIT PATCH] Showing abbreviated commit hash of the versions in Compare editor.) Robin Rosenberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200801110046.41786.robin.rosenberg.lists@dewire.com \
--to=robin.rosenberg.lists@dewire.com \
--cc=git@vger.kernel.org \
--cc=rogersoares@intelinet.com.br \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).