From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dennis Schridde Subject: Re: [PATCH] git-svn: handle leading/trailing whitespace from svnsync revprops Date: Sat, 12 Jan 2008 13:34:18 +0100 Message-ID: <200801121334.18632.devurandom@gmx.net> References: <200801081738.56624.devurandom@gmx.net> <7vmyrd5p81.fsf@gitster.siamese.dyndns.org> <20080112071355.GA17021@soma> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart2556348.yo8pmWMLZL"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Sat Jan 12 13:35:48 2008 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1JDfaV-0001xf-Nr for gcvg-git-2@gmane.org; Sat, 12 Jan 2008 13:35:48 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758969AbYALMfO (ORCPT ); Sat, 12 Jan 2008 07:35:14 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759036AbYALMfN (ORCPT ); Sat, 12 Jan 2008 07:35:13 -0500 Received: from mail.gmx.net ([213.165.64.20]:34569 "HELO mail.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1758969AbYALMfM (ORCPT ); Sat, 12 Jan 2008 07:35:12 -0500 Received: (qmail invoked by alias); 12 Jan 2008 12:35:10 -0000 Received: from hnvr-4dbb963c.pool.einsundeins.de (EHLO ernie.local) [77.187.150.60] by mail.gmx.net (mp020) with SMTP; 12 Jan 2008 13:35:10 +0100 X-Authenticated: #19202771 X-Provags-ID: V01U2FsdGVkX1/fwQcIdfLfgRvvFFXtTOT5BTMayouBD4psntQrO0 YV8gKCcbMeatM1 User-Agent: KMail/1.9.7 In-Reply-To: <20080112071355.GA17021@soma> X-Y-GMX-Trusted: 0 Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: --nextPart2556348.yo8pmWMLZL Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Am Samstag, 12. Januar 2008 08:13:55 schrieben Sie: > Repositories generated by svnsync cannot be relied on to have > properly set revprops without newlines in UUIDs and URLs. There > may be broken versions of svnsync out there that append extra > newlines to UUIDs, or the revprops could've been changed by > repository administrators at any time, too. > > At least one repository we've come across has an embedded > newline erroneously set in the svnsync-uuid prop. This is bad > because the trailing newline is taken as another record by the > Git.pm library, and the wantarray detection causes tmp_config() > to return an array with an empty-but-existing second element. > > We will now strip leading and trailing whitespace both before > setting and after reading the uuid and url for svnsync values. > We will also force tmp_config to return a single scalar when > reading existing values. > > SVN UUIDs should never have whitespace in them, and SVN > repository URLs should be URI-escaped, so neither of those > values we ever see in git-svn should actually have whitespace > in them. > > Thanks to Dennis Schridde for the bug report and Junio for > helping diagnose this. Thanks! This patch seems to work, at least the "Odd number..." message is=20 gone. The segfault with a non-debug perl stays, though. But I guess that is= a=20 different problem. =2D-Dennis --nextPart2556348.yo8pmWMLZL Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.7 (GNU/Linux) iD8DBQBHiLPKjqfyF1DtJW4RAtCjAKCiSEKm77VdHes8rbe+Z/tIqseS+QCgn5T4 xRnZIvDSZVl6aPo0kTj4Wtw= =6dif -----END PGP SIGNATURE----- --nextPart2556348.yo8pmWMLZL--