git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ls-remote: add -t and -h options.
@ 2008-01-15 20:34 Miklos Vajna
  2008-01-16  0:12 ` Johannes Schindelin
  0 siblings, 1 reply; 2+ messages in thread
From: Miklos Vajna @ 2008-01-15 20:34 UTC (permalink / raw)
  To: Junio C Hamano; +Cc: git

These options are listed in the manpage (aliases for --tags/--heads) but they
were not handled.

Signed-off-by: Miklos Vajna <vmiklos@frugalware.org>
---

Alternatively, if it's too late to introduce new options, I think we should
remove these options from the manpage, but I prefer the current fix.

 builtin-ls-remote.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/builtin-ls-remote.c b/builtin-ls-remote.c
index c2caeea..6dd31d1 100644
--- a/builtin-ls-remote.c
+++ b/builtin-ls-remote.c
@@ -54,11 +54,11 @@ int cmd_ls_remote(int argc, const char **argv, const char *prefix)
 				uploadpack = arg + 7;
 				continue;
 			}
-			if (!strcmp("--tags", arg)) {
+			if (!strcmp("--tags", arg) || !strcmp("-t", arg)) {
 				flags |= REF_TAGS;
 				continue;
 			}
-			if (!strcmp("--heads", arg)) {
+			if (!strcmp("--heads", arg) || !strcmp("-h", arg)) {
 				flags |= REF_HEADS;
 				continue;
 			}
-- 
1.5.4.rc3.4.g16335-dirty

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ls-remote: add -t and -h options.
  2008-01-15 20:34 [PATCH] ls-remote: add -t and -h options Miklos Vajna
@ 2008-01-16  0:12 ` Johannes Schindelin
  0 siblings, 0 replies; 2+ messages in thread
From: Johannes Schindelin @ 2008-01-16  0:12 UTC (permalink / raw)
  To: Miklos Vajna; +Cc: Junio C Hamano, git

Hi,

On Tue, 15 Jan 2008, Miklos Vajna wrote:

> These options are listed in the manpage (aliases for --tags/--heads) but 
> they were not handled.
> 
> Signed-off-by: Miklos Vajna <vmiklos@frugalware.org>
> ---
> 
> Alternatively, if it's too late to introduce new options, I think we 
> should remove these options from the manpage, but I prefer the current 
> fix.

It's not like you added functionality, but just short option handling.  
IMHO this is perfectly okay, even this late in the 1.5.4 cycle.

Ciao,
Dscho

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-01-16  0:13 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-01-15 20:34 [PATCH] ls-remote: add -t and -h options Miklos Vajna
2008-01-16  0:12 ` Johannes Schindelin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).