git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Narebski <jnareb@gmail.com>
To: "Catalin Marinas" <catalin.marinas@gmail.com>,
	"Peter Oberndorfer" <kumbayo84@arcor.de>
Cc: "Karl Hasselström" <kha@treskal.com>,
	"Dan McGee" <dpmcgee@gmail.com>,
	git@vger.kernel.org
Subject: Re: [STGIT PATCH] replace "git repo-config" usage by "git config"
Date: Fri, 18 Jan 2008 00:49:18 +0100	[thread overview]
Message-ID: <200801180049.19174.jnareb@gmail.com> (raw)
In-Reply-To: <b0943d9e0801170907x9c4721cy4e5ac886eb61e0a5@mail.gmail.com>

On Thu, 17 January 2008, Catalin Marinas wrote:
>
> Now I'm back from holiday and I'll start merging patches.
> Thanks for the fixes. 
> 
> On 16/01/2008, Jakub Narebski <jnareb@gmail.com> wrote:
> > Strange that StGIT didn't abstracted out reading git config, like
> > Git.pm and gitweb.perl did.
> 
> The initial implementation was to use Python to parse the config file
> but it was dropped in favour of the git-config tool. It might be a bit
> slower but, at least, we don't need to follow any future syntax
> changes.

Errr... this is not what I meant. What I meant here is why StGit doesn't
have a thin wrapper around "git config", so instead of all those calls
to "Run('git', 'config', '--get', name)" use "git_config(name)" etc.,
similarly to Git.pm and gitweb.perl (which also use git-config to parse
the config file; only git-cvsimport parses config file in Perl IIRC).

This way if you want to load the whole config file at once (like gitweb
now does, using "git config -z -l") you would have to make changes only
in one place.

-- 
Jakub Narebski
Poland

  reply	other threads:[~2008-01-17 23:44 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-16  3:19 [RFC/PATCH] Remove repo-config Dan McGee
2008-01-16  4:23 ` Junio C Hamano
2008-01-16  4:40   ` Dan McGee
2008-01-16 17:20     ` Junio C Hamano
2008-01-16 20:32       ` Junio C Hamano
2008-01-16 20:13 ` Junio C Hamano
2008-01-16 20:47 ` Peter Oberndorfer
2008-01-16 20:58   ` [STGIT PATCH] replace "git repo-config" usage by "git config" Peter Oberndorfer
2008-01-16 21:13     ` Jakub Narebski
2008-01-16 21:46       ` Peter Oberndorfer
2008-01-17 17:07       ` Catalin Marinas
2008-01-17 23:49         ` Jakub Narebski [this message]
2008-01-17  7:45     ` Karl Hasselström
2008-01-18  4:24       ` Karl Hasselström
2008-01-23 11:35         ` Catalin Marinas
2008-01-23 16:10           ` Karl Hasselström
2008-01-23 16:42             ` Catalin Marinas
2008-01-24  7:01               ` Karl Hasselström
2008-01-24 15:31                 ` Catalin Marinas
2008-01-24 18:08                   ` Karl Hasselström
2008-01-24 18:20                     ` Catalin Marinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200801180049.19174.jnareb@gmail.com \
    --to=jnareb@gmail.com \
    --cc=catalin.marinas@gmail.com \
    --cc=dpmcgee@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=kha@treskal.com \
    --cc=kumbayo84@arcor.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).