From: "Shawn O. Pearce" <spearce@spearce.org>
To: Mark Levedahl <mlevedahl@gmail.com>
Cc: git@vger.kernel.org, Mark Levedahl <mdl123@verizon.net>
Subject: Re: [PATCH] git-gui/Makefile - Handle $DESTDIR on Cygwin
Date: Thu, 17 Jan 2008 23:01:46 -0500 [thread overview]
Message-ID: <20080118040146.GY24004@spearce.org> (raw)
In-Reply-To: <1200628223-2280-1-git-send-email-mlevedahl@gmail.com>
Mark Levedahl <mlevedahl@gmail.com> wrote:
> From: Mark Levedahl <mdl123@verizon.net>
>
> gg_libdir is converted to an absolute Windows path on Cygwin,
> but a later step attempts to prefix $DESTDIR to install to a
> staging directory. Explicitly separate the uses of gg_libdir for
> these two purposes so installation to $DESTDIR will work.
>
> Signed-off-by: Mark Levedahl <mdl123@verizon.net>
> ---
> git-gui built with this passed tests on cygwin + tcl/tk 8.5,
> cygwin + normal tcl/tk, and linux. DESTDIR also works on cygwin,
> so I would suggest this rather than the previous patch.
Excellent. I was about to think about writing this patch myself,
but you beat me to it. I'm applying this and will include it as
part of git-gui 0.9.2, which should be in git 1.5.4.
Thanks.
--
Shawn.
prev parent reply other threads:[~2008-01-18 4:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-05 22:32 [PATCH] git-gui/Makefile - Don't convert gg_libdir on Cygwin Mark Levedahl
2008-01-16 6:40 ` Shawn O. Pearce
2008-01-17 1:09 ` Mark Levedahl
2008-01-18 3:50 ` [PATCH] git-gui/Makefile - Handle $DESTDIR " Mark Levedahl
2008-01-18 4:01 ` Shawn O. Pearce [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080118040146.GY24004@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=mdl123@verizon.net \
--cc=mlevedahl@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).