git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Shawn O. Pearce" <spearce@spearce.org>
To: "Blucher, Guy" <Guy.Blucher@dsto.defence.gov.au>
Cc: git@vger.kernel.org
Subject: Re: git gui and commit-msg hook
Date: Thu, 17 Jan 2008 23:12:30 -0500	[thread overview]
Message-ID: <20080118041230.GA24004@spearce.org> (raw)
In-Reply-To: <054F21930D24A0428E5B4588462C7AEDC5F8DC@ednex512.dsto.defence.gov.au>

"Blucher, Guy" <Guy.Blucher@dsto.defence.gov.au> wrote:
> Is the commit-msg hook supposed to work when using git gui to do a
> commit?

Uhhh.  Whoops.  ;-)

git-gui doesn't implement the commit-msg hook.  Because I forgot
to implement it.  So yes, its supposed to work, but no, it doesn't,
because it was never coded.  :-)
 
> All I want to do is verify that the text of a commit message follows
> some "corporate standard", perhaps I can do this using the pre-commit
> hook instead, but commit-msg seems to be the best fit?  

Yes, commit-msg is the proper hook to use here.  But git-gui doesn't
honor it.  I'll try to work out a fix after dinner this evening.

Thanks for the bug report.  Definately appreciated.

-- 
Shawn.

  reply	other threads:[~2008-01-18  4:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <054F21930D24A0428E5B4588462C7AEDC5F8DB@ednex512.dsto.defence.gov.au>
2008-01-16 23:13 ` git gui and commit-msg hook Blucher, Guy
2008-01-18  4:12   ` Shawn O. Pearce [this message]
2008-01-21  4:08   ` Shawn O. Pearce
2008-01-21  4:32     ` Junio C Hamano
2008-01-21  4:39       ` Shawn O. Pearce

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080118041230.GA24004@spearce.org \
    --to=spearce@spearce.org \
    --cc=Guy.Blucher@dsto.defence.gov.au \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).