From: "Karl Hasselström" <kha@treskal.com>
To: Eric Wong <normalperson@yhbt.net>
Cc: git@vger.kernel.org, Harvey Harrison <harvey.harrison@gmail.com>,
Kevin Ballard <kevin@sb.org>, Junio C Hamano <gitster@pobox.com>
Subject: [PATCH 1/2] git-svn: Don't call git-repack anymore
Date: Sun, 20 Jan 2008 22:39:51 +0100 [thread overview]
Message-ID: <20080120213847.9679.56653.stgit@yoghurt> (raw)
In-Reply-To: <20080120093436.GA10924@diana.vm.bytemark.co.uk>
In a moment, we'll start calling git-gc --auto instead, since it is a
better fit to what we're trying to accomplish.
The command line options are still accepted, but don't have any
effect, and we warn the user about that.
Signed-off-by: Karl Hasselström <kha@treskal.com>
---
Is this close enough to what you intended?
git-svn.perl | 14 ++------------
1 files changed, 2 insertions(+), 12 deletions(-)
diff --git a/git-svn.perl b/git-svn.perl
index 9f2b587..988d8f6 100755
--- a/git-svn.perl
+++ b/git-svn.perl
@@ -1247,7 +1247,6 @@ use File::Path qw/mkpath/;
use File::Copy qw/copy/;
use IPC::Open3;
-my $_repack_nr;
# properties that we do not log:
my %SKIP_PROP;
BEGIN {
@@ -1408,10 +1407,8 @@ sub read_all_remotes {
}
sub init_vars {
- if (defined $_repack) {
- $_repack = 1000 if ($_repack <= 0);
- $_repack_nr = $_repack;
- $_repack_flags ||= '-d';
+ if (defined $_repack || defined $_repack_flags) {
+ warn "Repack options are obsolete; they have no effect.\n";
}
}
@@ -2151,13 +2148,6 @@ sub do_git_commit {
0, $self->svm_uuid);
}
print " = $commit ($self->{ref_id})\n";
- if (defined $_repack && (--$_repack_nr == 0)) {
- $_repack_nr = $_repack;
- # repack doesn't use any arguments with spaces in them, does it?
- print "Running git repack $_repack_flags ...\n";
- command_noisy('repack', split(/\s+/, $_repack_flags));
- print "Done repacking\n";
- }
return $commit;
}
next prev parent reply other threads:[~2008-01-20 21:40 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-18 12:17 git-svn should default to --repack Kevin Ballard
2008-01-18 15:56 ` Karl Hasselström
2008-01-18 20:44 ` Junio C Hamano
2008-01-19 12:35 ` Karl Hasselström
2008-01-19 15:05 ` Kevin Ballard
2008-01-19 22:36 ` [PATCH] Let "git svn" run "git gc --auto" occasionally Karl Hasselström
2008-01-19 22:50 ` Harvey Harrison
2008-01-20 3:37 ` Eric Wong
2008-01-20 9:34 ` Karl Hasselström
2008-01-20 19:17 ` Junio C Hamano
2008-01-21 22:48 ` Eric Wong
2008-01-22 0:30 ` Junio C Hamano
2008-01-22 0:39 ` Eric Wong
2008-01-22 1:52 ` Junio C Hamano
2008-01-23 2:43 ` git filter-branch should run git gc --auto Kevin Ballard
2008-01-23 2:46 ` Junio C Hamano
2008-01-23 2:52 ` Junio C Hamano
2008-01-23 3:03 ` Kevin Ballard
2008-01-23 2:54 ` Harvey Harrison
2008-01-23 2:58 ` Kevin Ballard
2008-01-23 5:07 ` Sam Vilain
2008-01-23 8:18 ` Kevin Ballard
2008-01-23 6:44 ` Mike Hommey
2008-01-23 13:00 ` Johannes Schindelin
2008-01-23 19:22 ` Junio C Hamano
2008-02-03 16:55 ` [PATCH 0/2] "git svn" and "git gc --auto" Karl Hasselström
2008-02-03 16:56 ` [PATCH 1/2] git-svn: Don't call git-repack anymore Karl Hasselström
2008-02-03 16:56 ` [PATCH 2/2] Let "git svn" run "git gc --auto" occasionally Karl Hasselström
2008-01-20 21:39 ` Karl Hasselström [this message]
2008-01-20 21:40 ` Karl Hasselström
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080120213847.9679.56653.stgit@yoghurt \
--to=kha@treskal.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=harvey.harrison@gmail.com \
--cc=kevin@sb.org \
--cc=normalperson@yhbt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).