git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Robin Rosenberg <robin.rosenberg.lists@dewire.com>
To: "Roger C. Soares" <rogersoares@intelinet.com.br>
Cc: git@vger.kernel.org, "Shawn O. Pearce" <spearce@spearce.org>
Subject: Re: [EGIT PATCH] Removed Auto-generated TODOs, they don't specify something to do.
Date: Sun, 20 Jan 2008 22:07:27 +0100	[thread overview]
Message-ID: <200801202207.28128.robin.rosenberg.lists@dewire.com> (raw)
In-Reply-To: <1200860941-6922-1-git-send-email-rogersoares@intelinet.com.br>

söndagen den 20 januari 2008 skrev Roger C. Soares:
>                 } catch (IOException e) {
> -                       // TODO Auto-generated catch block
>                         e.printStackTrace();


Unfortunately it is not that easy. Most of the TODO's are left there 
intentionally. They signal work to do, i.e. proper error handling. At minimum 
we should use Eclipse's error logging. For JGit we could encapsulate it a 
little as we don't have direct access to the Eclipse runtime there.

BTW JGit is currently mostly GPL'ed. I want to have your permission to 
relicense anything you contribute there under the EPL (Eclipse Public 
License), just in case we go down that road and make it an Eclipse project.

You put a finger on a sore point. We'll see if I can find a way to replace
those TODO's with something sensible.

Also, please Cc: directly for egit patches. Shawn, want Cc: to?

-- robin

  reply	other threads:[~2008-01-20 21:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-20 20:29 [EGIT PATCH] Removed Auto-generated TODOs, they don't specify something to do Roger C. Soares
2008-01-20 21:07 ` Robin Rosenberg [this message]
2008-01-21  1:27   ` Roger C. Soares

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200801202207.28128.robin.rosenberg.lists@dewire.com \
    --to=robin.rosenberg.lists@dewire.com \
    --cc=git@vger.kernel.org \
    --cc=rogersoares@intelinet.com.br \
    --cc=spearce@spearce.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).