* [EGIT PATCH] Removed Auto-generated TODOs, they don't specify something to do.
@ 2008-01-20 20:29 Roger C. Soares
2008-01-20 21:07 ` Robin Rosenberg
0 siblings, 1 reply; 3+ messages in thread
From: Roger C. Soares @ 2008-01-20 20:29 UTC (permalink / raw)
To: git; +Cc: Roger C. Soares
Signed-off-by: Roger C. Soares <rogersoares@intelinet.com.br>
---
.../src/org/spearce/egit/core/GitBlobStorage.java | 3 ---
.../src/org/spearce/egit/core/GitStorage.java | 4 ----
.../internal/mapping/GitCommitFileRevision.java | 1 -
.../src/org/spearce/egit/ui/GitHistoryPage.java | 9 ---------
.../internal/decorators/GitResourceDecorator.java | 7 -------
.../ui/internal/factories/GitAdapterFactory.java | 1 -
.../org/spearce/jgit/lib/TopologicalWalker.java | 1 -
.../src/org/spearce/jgit/lib/Walker.java | 1 -
8 files changed, 0 insertions(+), 27 deletions(-)
diff --git a/org.spearce.egit.core/src/org/spearce/egit/core/GitBlobStorage.java b/org.spearce.egit.core/src/org/spearce/egit/core/GitBlobStorage.java
index f7a062c..65bbb5d 100644
--- a/org.spearce.egit.core/src/org/spearce/egit/core/GitBlobStorage.java
+++ b/org.spearce.egit.core/src/org/spearce/egit/core/GitBlobStorage.java
@@ -52,7 +52,6 @@ public class GitBlobStorage implements IStorage {
String name = repositoryMapping.getRepoRelativePath(resource);
entry = tree.findBlobMember(name);
} catch (IOException e) {
- // TODO Auto-generated catch block
e.printStackTrace();
}
}
@@ -71,7 +70,6 @@ public class GitBlobStorage implements IStorage {
throw new ResourceException(IResourceStatus.FAILED_READ_LOCAL,
resource.getFullPath(), "Could not read file", e);
} catch (IOException e) {
- // TODO Auto-generated catch block
e.printStackTrace();
throw new ResourceException(33, resource.getFullPath(), e
.getMessage(), e);
@@ -87,7 +85,6 @@ public class GitBlobStorage implements IStorage {
}
public boolean isReadOnly() {
- // TODO Auto-generated method stub
return false;
}
diff --git a/org.spearce.egit.core/src/org/spearce/egit/core/GitStorage.java b/org.spearce.egit.core/src/org/spearce/egit/core/GitStorage.java
index f791e31..70b9f1a 100644
--- a/org.spearce.egit.core/src/org/spearce/egit/core/GitStorage.java
+++ b/org.spearce.egit.core/src/org/spearce/egit/core/GitStorage.java
@@ -69,7 +69,6 @@ public class GitStorage implements IStorage {
entry = treeEntry.getId();
}
} catch (IOException e) {
- // TODO Auto-generated catch block
e.printStackTrace();
}
}
@@ -93,7 +92,6 @@ public class GitStorage implements IStorage {
throw new ResourceException(IResourceStatus.FAILED_READ_LOCAL,
resource.getFullPath(), "Could not read file", e);
} catch (IOException e) {
- // TODO Auto-generated catch block
e.printStackTrace();
throw new ResourceException(33, resource.getFullPath(), e
.getMessage(), e);
@@ -109,12 +107,10 @@ public class GitStorage implements IStorage {
}
public boolean isReadOnly() {
- // TODO Auto-generated method stub
return false;
}
public Object getAdapter(Class adapter) {
- // TODO Auto-generated method stub
return null;
}
diff --git a/org.spearce.egit.core/src/org/spearce/egit/core/internal/mapping/GitCommitFileRevision.java b/org.spearce.egit.core/src/org/spearce/egit/core/internal/mapping/GitCommitFileRevision.java
index 6d6f7ea..da0444f 100644
--- a/org.spearce.egit.core/src/org/spearce/egit/core/internal/mapping/GitCommitFileRevision.java
+++ b/org.spearce.egit.core/src/org/spearce/egit/core/internal/mapping/GitCommitFileRevision.java
@@ -134,7 +134,6 @@ public class GitCommitFileRevision extends GitFileRevision {
else
return tree.findTreeMember(path);
} catch (IOException e) {
- // TODO Auto-generated catch block
e.printStackTrace();
}
return null;
diff --git a/org.spearce.egit.ui/src/org/spearce/egit/ui/GitHistoryPage.java b/org.spearce.egit.ui/src/org/spearce/egit/ui/GitHistoryPage.java
index 649df3f..1707859 100644
--- a/org.spearce.egit.ui/src/org/spearce/egit/ui/GitHistoryPage.java
+++ b/org.spearce.egit.ui/src/org/spearce/egit/ui/GitHistoryPage.java
@@ -155,7 +155,6 @@ public class GitHistoryPage extends HistoryPage implements IAdaptable,
public boolean inputSet() {
if (viewer != null)
viewer.setInput(getInput());
- // TODO Auto-generated method stub
return true;
}
@@ -875,7 +874,6 @@ public class GitHistoryPage extends HistoryPage implements IAdaptable,
try {
newappliedPatches = repositoryMapping.getRepository().getAppliedPatches();
} catch (IOException e) {
- // TODO Auto-generated catch block
e.printStackTrace();
}
Map<ObjectId,Tag[]> newtags = new HashMap<ObjectId,Tag[]>();
@@ -895,13 +893,11 @@ public class GitHistoryPage extends HistoryPage implements IAdaptable,
newtags.put(t.getObjId(), samecommit);
}
} catch (IOException e) {
- // TODO Auto-generated catch block
e.printStackTrace();
}
try {
currentHead = repositoryMapping.getRepository().resolve("HEAD");
} catch (IOException e) {
- // TODO Auto-generated catch block
e.printStackTrace();
}
Map<ObjectId, String[]> newBranches = new HashMap<ObjectId, String[]>();
@@ -933,7 +929,6 @@ public class GitHistoryPage extends HistoryPage implements IAdaptable,
newBranches.put(currentHead, samecommit);
branches = newBranches;
} catch (IOException e) {
- // TODO Auto-generated catch block
e.printStackTrace();
}
GitFileHistoryProvider fileHistoryProvider = (GitFileHistoryProvider) provider
@@ -1092,12 +1087,10 @@ public class GitHistoryPage extends HistoryPage implements IAdaptable,
}
public boolean isValidInput(Object object) {
- // TODO Auto-generated method stub
return true;
}
public void refresh() {
- // TODO Auto-generated method stub
}
@@ -1109,14 +1102,12 @@ public class GitHistoryPage extends HistoryPage implements IAdaptable,
}
public ICompareInput getCompareInput(Object object) {
- // TODO Auto-generated method stub
return null;
}
public void prepareInput(ICompareInput input,
CompareConfiguration configuration, IProgressMonitor monitor) {
System.out.println("prepareInput()");
- // TODO Auto-generated method stub
}
/**
diff --git a/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/decorators/GitResourceDecorator.java b/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/decorators/GitResourceDecorator.java
index c13c38a..9ab762a 100644
--- a/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/decorators/GitResourceDecorator.java
+++ b/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/decorators/GitResourceDecorator.java
@@ -89,7 +89,6 @@ public class GitResourceDecorator extends LabelProvider implements
}
});
} catch (CoreException e) {
- // TODO Auto-generated catch block
e.printStackTrace();
}
start();
@@ -129,7 +128,6 @@ public class GitResourceDecorator extends LabelProvider implements
// Activator.trace("VCLEARING:"+r.getFullPath().toOSString());
clearDecorationState(r);
} catch (CoreException e) {
- // TODO Auto-generated catch block
e.printStackTrace();
}
}
@@ -138,7 +136,6 @@ public class GitResourceDecorator extends LabelProvider implements
});
} catch (CoreException e2) {
- // TODO Auto-generated catch block
e2.printStackTrace();
return;
}
@@ -211,10 +208,8 @@ public class GitResourceDecorator extends LabelProvider implements
}
return null; // not mapped
} catch (CoreException e) {
- // TODO Auto-generated catch block
e.printStackTrace();
} catch (IOException e) {
- // TODO Auto-generated catch block
e.printStackTrace();
}
return null;
@@ -342,7 +337,6 @@ public class GitResourceDecorator extends LabelProvider implements
//
throw new RuntimeException(UIText.Decorator_failedLazyLoading, e);
} catch (CoreException e) {
- // TODO Auto-generated catch block
e.printStackTrace();
throw new RuntimeException(UIText.Decorator_failedLazyLoading, e);
}
@@ -394,7 +388,6 @@ public class GitResourceDecorator extends LabelProvider implements
}
}
} catch (CoreException e) {
- // TODO Auto-generated catch block
e.printStackTrace();
}
}
diff --git a/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/factories/GitAdapterFactory.java b/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/factories/GitAdapterFactory.java
index 53d222a..74b8efa 100644
--- a/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/factories/GitAdapterFactory.java
+++ b/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/factories/GitAdapterFactory.java
@@ -43,7 +43,6 @@ public class GitAdapterFactory implements IAdapterFactory {
}
public Class[] getAdapterList() {
- // TODO Auto-generated method stub
return null;
}
diff --git a/org.spearce.jgit/src/org/spearce/jgit/lib/TopologicalWalker.java b/org.spearce.jgit/src/org/spearce/jgit/lib/TopologicalWalker.java
index 16af0c6..3da6b03 100644
--- a/org.spearce.jgit/src/org/spearce/jgit/lib/TopologicalWalker.java
+++ b/org.spearce.jgit/src/org/spearce/jgit/lib/TopologicalWalker.java
@@ -105,7 +105,6 @@ public class TopologicalWalker extends Walker {
try {
collectSortOrder(succ, repository.mapCommit(succ));
} catch (IOException e) {
- // TODO Auto-generated catch block
e.printStackTrace();
}
}
diff --git a/org.spearce.jgit/src/org/spearce/jgit/lib/Walker.java b/org.spearce.jgit/src/org/spearce/jgit/lib/Walker.java
index 1f6c531..ca67969 100644
--- a/org.spearce.jgit/src/org/spearce/jgit/lib/Walker.java
+++ b/org.spearce.jgit/src/org/spearce/jgit/lib/Walker.java
@@ -104,7 +104,6 @@ public abstract class Walker {
try {
next.run();
} catch (IOException e) {
- // TODO Auto-generated catch block
e.printStackTrace();
}
todo.remove(next);
--
1.5.3.7
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [EGIT PATCH] Removed Auto-generated TODOs, they don't specify something to do.
2008-01-20 20:29 [EGIT PATCH] Removed Auto-generated TODOs, they don't specify something to do Roger C. Soares
@ 2008-01-20 21:07 ` Robin Rosenberg
2008-01-21 1:27 ` Roger C. Soares
0 siblings, 1 reply; 3+ messages in thread
From: Robin Rosenberg @ 2008-01-20 21:07 UTC (permalink / raw)
To: Roger C. Soares; +Cc: git, Shawn O. Pearce
söndagen den 20 januari 2008 skrev Roger C. Soares:
> } catch (IOException e) {
> - // TODO Auto-generated catch block
> e.printStackTrace();
Unfortunately it is not that easy. Most of the TODO's are left there
intentionally. They signal work to do, i.e. proper error handling. At minimum
we should use Eclipse's error logging. For JGit we could encapsulate it a
little as we don't have direct access to the Eclipse runtime there.
BTW JGit is currently mostly GPL'ed. I want to have your permission to
relicense anything you contribute there under the EPL (Eclipse Public
License), just in case we go down that road and make it an Eclipse project.
You put a finger on a sore point. We'll see if I can find a way to replace
those TODO's with something sensible.
Also, please Cc: directly for egit patches. Shawn, want Cc: to?
-- robin
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [EGIT PATCH] Removed Auto-generated TODOs, they don't specify something to do.
2008-01-20 21:07 ` Robin Rosenberg
@ 2008-01-21 1:27 ` Roger C. Soares
0 siblings, 0 replies; 3+ messages in thread
From: Roger C. Soares @ 2008-01-21 1:27 UTC (permalink / raw)
To: Robin Rosenberg; +Cc: git, Shawn O. Pearce
Robin Rosenberg escreveu:
> Unfortunately it is not that easy. Most of the TODO's are left there
> intentionally. They signal work to do, i.e. proper error handling. At minimum
> we should use Eclipse's error logging. For JGit we could encapsulate it a
> little as we don't have direct access to the Eclipse runtime there.
>
Ok.
> BTW JGit is currently mostly GPL'ed. I want to have your permission to
> relicense anything you contribute there under the EPL (Eclipse Public
> License), just in case we go down that road and make it an Eclipse project.
>
Sure, permission granted.
> You put a finger on a sore point. We'll see if I can find a way to replace
> those TODO's with something sensible.
>
> Also, please Cc: directly for egit patches. Shawn, want Cc: to?
>
> -- robin
>
Ok.
[]s,
Roger.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-01-21 1:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-01-20 20:29 [EGIT PATCH] Removed Auto-generated TODOs, they don't specify something to do Roger C. Soares
2008-01-20 21:07 ` Robin Rosenberg
2008-01-21 1:27 ` Roger C. Soares
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).