git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Shawn O. Pearce" <spearce@spearce.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Blucher, Guy" <Guy.Blucher@dsto.defence.gov.au>, git@vger.kernel.org
Subject: Re: git gui and commit-msg hook
Date: Sun, 20 Jan 2008 23:39:47 -0500	[thread overview]
Message-ID: <20080121043947.GG24004@spearce.org> (raw)
In-Reply-To: <7vmyqz3ijb.fsf@gitster.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> wrote:
> "Shawn O. Pearce" <spearce@spearce.org> writes:
> 
> > "Blucher, Guy" <Guy.Blucher@dsto.defence.gov.au> wrote:
> >> I've just setup a commit-msg hook in my local repository.  It works as
> >> advertised from the command-line when using git commit, but if I use git
> >> gui to do the commit, then the hook is ignored.
> >
> > Fixed in my latest git-gui master, which will be gitgui-0.9.2 or .3.
> >
> > I apparently missed git 1.5.4-rc4, but will have to ask Junio nicely
> > if this can be included into 1.5.4 final.
> 
> Absolutely.  That's a consistency-and-usability bugfix, isn't
> it?

I consider it a bug fix for git-gui, but some may say its a new
feature since git-gui didn't have a commit-msg hook before this
change.  :)

Anyway, its now published on repo.or.cz if you want to include
it into your next published git.git master to try and get it
some more testing before 1.5.4 goes final.

I'm pretty happy with what's in my master right now.  I'm actually
tempted to tag it gitgui-0.9.2 and say that's the final version
we're including in 1.5.4.

-- 
Shawn.

      reply	other threads:[~2008-01-21  4:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <054F21930D24A0428E5B4588462C7AEDC5F8DB@ednex512.dsto.defence.gov.au>
2008-01-16 23:13 ` git gui and commit-msg hook Blucher, Guy
2008-01-18  4:12   ` Shawn O. Pearce
2008-01-21  4:08   ` Shawn O. Pearce
2008-01-21  4:32     ` Junio C Hamano
2008-01-21  4:39       ` Shawn O. Pearce [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080121043947.GG24004@spearce.org \
    --to=spearce@spearce.org \
    --cc=Guy.Blucher@dsto.defence.gov.au \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).