From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Shawn O. Pearce" Subject: Re: git gui and commit-msg hook Date: Sun, 20 Jan 2008 23:39:47 -0500 Message-ID: <20080121043947.GG24004@spearce.org> References: <054F21930D24A0428E5B4588462C7AEDC5F8DB@ednex512.dsto.defence.gov.au> <054F21930D24A0428E5B4588462C7AEDC5F8DC@ednex512.dsto.defence.gov.au> <20080121040819.GE24004@spearce.org> <7vmyqz3ijb.fsf@gitster.siamese.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Cc: "Blucher, Guy" , git@vger.kernel.org To: Junio C Hamano X-From: git-owner@vger.kernel.org Mon Jan 21 05:40:24 2008 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1JGoSL-00011z-Fx for gcvg-git-2@gmane.org; Mon, 21 Jan 2008 05:40:21 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756958AbYAUEjw (ORCPT ); Sun, 20 Jan 2008 23:39:52 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756961AbYAUEjv (ORCPT ); Sun, 20 Jan 2008 23:39:51 -0500 Received: from corvette.plexpod.net ([64.38.20.226]:56943 "EHLO corvette.plexpod.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756950AbYAUEjv (ORCPT ); Sun, 20 Jan 2008 23:39:51 -0500 Received: from cpe-74-70-48-173.nycap.res.rr.com ([74.70.48.173] helo=asimov.home.spearce.org) by corvette.plexpod.net with esmtpa (Exim 4.68) (envelope-from ) id 1JGoRc-0006z8-35; Sun, 20 Jan 2008 23:39:36 -0500 Received: by asimov.home.spearce.org (Postfix, from userid 1000) id 815A620FBAE; Sun, 20 Jan 2008 23:39:47 -0500 (EST) Content-Disposition: inline In-Reply-To: <7vmyqz3ijb.fsf@gitster.siamese.dyndns.org> User-Agent: Mutt/1.5.11 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - corvette.plexpod.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - spearce.org Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Junio C Hamano wrote: > "Shawn O. Pearce" writes: > > > "Blucher, Guy" wrote: > >> I've just setup a commit-msg hook in my local repository. It works as > >> advertised from the command-line when using git commit, but if I use git > >> gui to do the commit, then the hook is ignored. > > > > Fixed in my latest git-gui master, which will be gitgui-0.9.2 or .3. > > > > I apparently missed git 1.5.4-rc4, but will have to ask Junio nicely > > if this can be included into 1.5.4 final. > > Absolutely. That's a consistency-and-usability bugfix, isn't > it? I consider it a bug fix for git-gui, but some may say its a new feature since git-gui didn't have a commit-msg hook before this change. :) Anyway, its now published on repo.or.cz if you want to include it into your next published git.git master to try and get it some more testing before 1.5.4 goes final. I'm pretty happy with what's in my master right now. I'm actually tempted to tag it gitgui-0.9.2 and say that's the final version we're including in 1.5.4. -- Shawn.