From: Jeff King <peff@peff.net>
To: Gustaf Hendeby <hendeby@isy.liu.se>
Cc: Seth Falcon <seth@userprimary.net>,
gitster@pobox.com, git@vger.kernel.org
Subject: Re: [PATCH] send-email, fix breakage in combination with --compose
Date: Mon, 21 Jan 2008 22:19:32 -0500 [thread overview]
Message-ID: <20080122031932.GA24758@coredump.intra.peff.net> (raw)
In-Reply-To: <1200945466-21154-2-git-send-email-hendeby@isy.liu.se>
On Mon, Jan 21, 2008 at 08:57:46PM +0100, Gustaf Hendeby wrote:
> This fixes the subtile bug in git send-email that was introduced into
> git send-email with
>
> commit aa54892f5ada8282643dc7387b33261c7135d784
> send-email: detect invocation errors earlier
Sorry, this was my fault. I have looked over the code again to make sure
there are not any other places where the movement of @files should
matter, but this seems to be the only one.
As penance, I'll send some tests in a moment.
> - @files = ($compose_filename . ".final");
> + @files = ($compose_filename . ".final", @files);
I think this might be more readable as
unshift @files, "$compose_filename.final";
but either way it fixes the bug, so
Acked-by: Jeff King <peff@peff.net>
-Peff
next prev parent reply other threads:[~2008-01-22 3:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-21 18:30 git-send-email not sending? Seth Falcon
2008-01-21 19:57 ` Test of send-email patch Gustaf Hendeby
2008-01-21 19:57 ` [PATCH] send-email, fix breakage in combination with --compose Gustaf Hendeby
2008-01-22 0:05 ` Seth Falcon
2008-01-22 3:19 ` Jeff King [this message]
2008-01-22 3:23 ` [PATCH 1/3] t9001: add missing && operators Jeff King
2008-01-22 3:25 ` [PATCH 2/3] t9001: enhance fake sendmail test harness Jeff King
2008-01-22 3:29 ` [PATCH 3/3] send-email: test compose functionality Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080122031932.GA24758@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=hendeby@isy.liu.se \
--cc=seth@userprimary.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).