From: Jeff King <peff@peff.net>
To: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Cc: "François Pinard" <pinard@iro.umontreal.ca>,
"git mailing list" <git@vger.kernel.org>
Subject: Re: Tiny bug report, interaction between alias and help
Date: Mon, 21 Jan 2008 22:43:29 -0500 [thread overview]
Message-ID: <20080122034329.GA1271@coredump.intra.peff.net> (raw)
In-Reply-To: <fcaeb9bf0801200159k26303a18ned2eef8e6b5b65d2@mail.gmail.com>
On Sun, Jan 20, 2008 at 04:59:13PM +0700, Nguyen Thai Ngoc Duy wrote:
> I've been hit by this and came up with a similar approach as well. But
> I dropped it because it made aliases higher precedence than git-foo
> while git aliases cannot override git-foo (builtin or external ones).
> Is there any other way to make "git-help" respect git command
> executing order?
Yes, and that is an issue in my refactored patch as well. The tricky
thing is that usually we say "try git-foo as a real git command, and
then fall back to aliases" but we can't here, because "try git-foo"
involves exec'ing something else.
It should be possible to do a lookup on "git-foo" and find out if it is
a real git command, but I don't know how involved that will be. I'll
look at it before I resend post-1.5.4.
And of course the other option is "so what?" People with alias.commit
set will get the alias text rather than the man page. But they will
quickly figure out that alias.commit doesn't actually _work_, and
presumably remove it.
-Peff
prev parent reply other threads:[~2008-01-22 3:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-19 14:27 Tiny bug report, interaction between alias and help François Pinard
2008-01-19 15:23 ` Pascal Obry
2008-01-19 17:41 ` Jeff King
2008-01-19 22:55 ` Johannes Schindelin
2008-01-19 22:57 ` Jeff King
2008-01-19 23:23 ` Johannes Schindelin
[not found] ` <fcaeb9bf0801200159k26303a18ned2eef8e6b5b65d2@mail.gmail.com>
2008-01-22 3:43 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080122034329.GA1271@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
--cc=pinard@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).