git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Karl Hasselström" <kha@treskal.com>
To: Jon Smirl <jonsmirl@gmail.com>
Cc: git@vger.kernel.org, Catalin Marinas <catalin.marinas@gmail.com>,
	Yann Dirson <ydirson@altern.org>
Subject: [StGit PATCH 0/4] --diff-opts in config file
Date: Thu, 24 Jan 2008 09:06:54 +0100	[thread overview]
Message-ID: <20080124075935.25525.24416.stgit@yoghurt> (raw)
In-Reply-To: <20080124074827.GA29572@nan92-1-81-57-214-146.fbx.proxad.net>

This is first two cleanup patches, followed by one patch that makes
"stg show" handle diff options like the other commands, and last a
patch that reads diff opts from the config file.

The first two patches are in kha/safe, but the latter two are in
kha/experimental because -- as Yann pointed out -- it's good to make
sure the design is OK before committing to it.

I've solved the problem of overriding the config on the command line
by making --diff-opts='--foo --bar' _add_ options, and special-cased
--diff-opts='' to clear all options, including those from the config
file, since appending no options makes no sense.

We'll still have to consider if and how to support different options
for different tools.

Oh, and Jon: is this what you wanted, by the way? :-)

---

Karl Hasselström (4):
      Read default diff options from the user's config
      Let "stg show" use the unified --diff-opts handling
      Refactor --diff-opts handling
      Remove unused default values


 examples/gitconfig       |    4 ++++
 stgit/commands/diff.py   |   14 ++++----------
 stgit/commands/edit.py   |   14 +++-----------
 stgit/commands/export.py |   12 +++---------
 stgit/commands/files.py  |   13 ++++---------
 stgit/commands/mail.py   |   12 +++---------
 stgit/commands/show.py   |   13 ++++---------
 stgit/commands/status.py |   17 +++++------------
 stgit/utils.py           |   13 +++++++++++++
 9 files changed, 43 insertions(+), 69 deletions(-)

-- 
Karl Hasselström, kha@treskal.com
      www.treskal.com/kalle

  reply	other threads:[~2008-01-24  8:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-23  3:04 stgit: config option for diff-opts Jon Smirl
2008-01-23  3:18 ` Karl Hasselström
2008-01-24  7:48   ` Yann Dirson
2008-01-24  8:06     ` Karl Hasselström [this message]
2008-01-24  8:07       ` [StGit PATCH 1/4] Remove unused default values Karl Hasselström
2008-01-24  8:07       ` [StGit PATCH 2/4] Refactor --diff-opts handling Karl Hasselström
2008-01-24  8:08       ` [StGit PATCH 3/4] Let "stg show" use the unified " Karl Hasselström
2008-01-24  8:08       ` [StGit PATCH 4/4] Read default diff options from the user's config Karl Hasselström
2008-01-24  8:18       ` [StGit PATCH 0/4] --diff-opts in config file Karl Hasselström
2008-01-24 20:20       ` Jon Smirl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080124075935.25525.24416.stgit@yoghurt \
    --to=kha@treskal.com \
    --cc=catalin.marinas@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=jonsmirl@gmail.com \
    --cc=ydirson@altern.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).