From: Robert Schiele <rschiele@gmail.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH] HP-UX traditionally has no sys/select.h
Date: Thu, 24 Jan 2008 19:36:45 +0100 [thread overview]
Message-ID: <20080124183645.GL30676@schiele.dyndns.org> (raw)
In-Reply-To: <alpine.LSU.1.00.0801241758130.5731@racer.site>
[-- Attachment #1: Type: text/plain, Size: 822 bytes --]
On Thu, Jan 24, 2008 at 06:03:14PM +0000, Johannes Schindelin wrote:
> We try to avoid using constructs like this. Rather, we have a section in
> the Makefile which sets things like NO_IPV6=YesPlease,
> OLD_ICONV=UnfortunatelyYes, etc.
>
> Later in the Makefile, dependent on this Makefile variable, symbols
> are defined. In the source code, we check for these symbols.
>
> It is not only a matter of being able to reuse the same symbol for another
> platform/setup, it is also a nice way of documentation.
>
> In your case, I suggest NO_SYS_SELECT_H=UnfortunatelyYes.
Ok, implemented it that way now and also made HP-UX support in Makefile in a
separate patch.
Robert
--
Robert Schiele
Dipl.-Wirtsch.informatiker mailto:rschiele@gmail.com
"Quidquid latine dictum sit, altum sonatur."
[-- Attachment #2: Type: application/pgp-signature, Size: 194 bytes --]
next prev parent reply other threads:[~2008-01-24 18:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-24 17:53 [PATCH] HP-UX traditionally has no sys/select.h Robert Schiele
2008-01-24 18:03 ` Johannes Schindelin
2008-01-24 18:36 ` Robert Schiele [this message]
2008-01-24 19:11 ` Junio C Hamano
2008-01-24 19:39 ` Robert Schiele
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080124183645.GL30676@schiele.dyndns.org \
--to=rschiele@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).