From: Charles Bailey <charles@hashpling.org>
To: Pascal Obry <pascal@obry.net>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Pascal Obry <pascal.obry@gmail.com>,
git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH] Check for -amend as a common wrong usage of --amend.
Date: Thu, 24 Jan 2008 19:25:32 +0000 [thread overview]
Message-ID: <20080124192532.GA3389@hashpling.org> (raw)
In-Reply-To: <4798DE6A.1050201@obry.net>
On Thu, Jan 24, 2008 at 07:52:26PM +0100, Pascal Obry wrote:
> Johannes Schindelin a écrit :
> >That is ugly. In a source file which is by no means specific to
> >git-commit, you cannot possibly mean to check for "amend".
>
> Agreed :( I'll try to come with something better.
>
> Pascal.
>
Would this be better handled by a commit-msg hook. E.g.:
test "$(cat $1)" = "end" && {
echo >&2 Commit message is \"end\", possible mis-type of --amend
echo >&2 Use --no-verify to really commit with this commit message
exit 1
}
next prev parent reply other threads:[~2008-01-24 19:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-24 18:13 [PATCH] Check for -amend as a common wrong usage of --amend Pascal Obry
2008-01-24 18:16 ` Pascal Obry
2008-01-26 0:10 ` Jörg Sommer
2008-01-24 18:20 ` Johannes Schindelin
2008-01-24 18:52 ` Pascal Obry
2008-01-24 19:25 ` Charles Bailey [this message]
2008-01-24 19:35 ` Pascal Obry
2008-01-24 20:47 ` Joey Hess
2008-01-26 6:20 ` Junio C Hamano
2008-01-26 10:42 ` Pierre Habouzit
2008-01-26 11:26 ` [PATCH] parse-options: catch some likely in presense of aggregated options Pierre Habouzit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080124192532.GA3389@hashpling.org \
--to=charles@hashpling.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pascal.obry@gmail.com \
--cc=pascal@obry.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).