From: mkoegler@auto.tuwien.ac.at (Martin Koegler)
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH 2/3] fsck_commit: remove duplicate tests
Date: Mon, 4 Feb 2008 08:06:00 +0100 [thread overview]
Message-ID: <20080204070600.GA30099@auto.tuwien.ac.at> (raw)
In-Reply-To: <alpine.LSU.1.00.0802040003360.7372@racer.site>
On Mon, Feb 04, 2008 at 12:04:31AM +0000, Johannes Schindelin wrote:
> On Sun, 3 Feb 2008, Junio C Hamano wrote:
> > Martin Koegler <mkoegler@auto.tuwien.ac.at> writes:
> >
> > > All tests on the commit buffer in fsck_cmd are ready done by
> > > parse_commit_buffer.
> > >
> > > This patch rips out all redundant tests.
> >
> > As I believe in belt-and-suspenders when it comes to validation, I am
> > somewhat uneasy with this change.
>
> Besides, should we really change fsck? It's not _that_ much of a
> performance-critical operation. Accuracy is much more important.
>
> fsck is the reason I trust git with my data.
Then please drop this patch. I hope the other two patches are OK.
mfg Martin Kögler
next prev parent reply other threads:[~2008-02-04 7:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-03 21:22 [PATCH 1/3] git-fsck: report missing author/commit line in a commit as an error Martin Koegler
2008-02-03 21:22 ` [PATCH 2/3] fsck_commit: remove duplicate tests Martin Koegler
2008-02-03 21:22 ` [PATCH 3/3] parse_object_buffer: don't ignore errors from the object specific parsing functions Martin Koegler
2008-02-03 23:58 ` [PATCH 2/3] fsck_commit: remove duplicate tests Junio C Hamano
2008-02-04 0:04 ` Johannes Schindelin
2008-02-04 7:06 ` Martin Koegler [this message]
2008-02-04 7:33 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080204070600.GA30099@auto.tuwien.ac.at \
--to=mkoegler@auto.tuwien.ac.at \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).