git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tim Stoakes <tim@stoakes.net>
To: Wincent Colaiuta <win@wincent.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] git-stash: alias 'list' to 'ls' and 'clear' to 'rm'
Date: Tue, 5 Feb 2008 21:50:01 +1030	[thread overview]
Message-ID: <20080205112000.GD29545@mail.stoakes.net> (raw)
In-Reply-To: <D512F3C0-3354-40BB-BD8D-8B3A85196825@wincent.com>

Wincent Colaiuta(win@wincent.com)@050208-12:06:
> El 5/2/2008, a las 11:38, Tim Stoakes escribi?:
>
>> clear::
>> +rm::
>> 	Remove all the stashed states. Note that those states will then
>> 	be subject to pruning, and may be difficult or impossible to recover.
>
> Isn't "rm" a bit misleading here? Seeing as the clear subcommand really 
> does an "rm -rf".

$ git stash clear foo
git stash clear with parameters is unimplemented

It appears that 'clear' is intended to behave like 'rm', however, it
isn't implemented yet.

> Also, is there any other precedent in the command suite for abbreviating 
> subcommand names in that way (ie. not just by shortening them, but by using 
> alternative names based on filesystem commands)? It strikes me as a bit 
> inconsistent.

For example 'git remote' uses 'rm', and there exists 'git rm', 'git
ls-files', 'git ls-remotes' etc. Granted, these are not abbreviations of
other (also available) longer term. The fact that some commands use
shell command names, and others use words, appears to be the
inconsistency to me. However, renaming 'git stash list' to 'git stash
ls' would break compatibility, so seemed too heavy to me.

Tim

-- 
Tim Stoakes

  reply	other threads:[~2008-02-05 11:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-05 10:38 [PATCH] git-stash: alias 'list' to 'ls' and 'clear' to 'rm' Tim Stoakes
2008-02-05 11:06 ` Wincent Colaiuta
2008-02-05 11:20   ` Tim Stoakes [this message]
2008-02-05 12:12     ` Wincent Colaiuta
2008-02-05 14:03       ` Johannes Schindelin
2008-02-06 16:19         ` [PATCH WIP] git-stash: add new 'drop' subcommand Brandon Casey
2008-02-06 17:11           ` Paolo Bonzini
2008-02-06 19:44             ` Junio C Hamano
2008-02-06 23:53           ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080205112000.GD29545@mail.stoakes.net \
    --to=tim@stoakes.net \
    --cc=git@vger.kernel.org \
    --cc=win@wincent.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).