From: Robin Rosenberg <robin.rosenberg@dewire.com>
To: "Roger C. Soares" <rogersoares@intelinet.com.br>
Cc: git@vger.kernel.org, Dave Watson <dwatson@mimvista.com>,
"Shawn O. Pearce" <spearce@spearce.org>
Subject: Re: [EGIT PATCH Series] Cleanups and javadocs
Date: Tue, 5 Feb 2008 22:47:47 +0100 [thread overview]
Message-ID: <200802052247.47744.robin.rosenberg@dewire.com> (raw)
In-Reply-To: <47A87C26.2070307@intelinet.com.br>
tisdagen den 5 februari 2008 skrev Roger C. Soares:
>
> Robin Rosenberg escreveu:
> > Here is a number of small enhancements that reduce the number of warnings
> > displayed and raises the standard on comments. We now get javadoc comments
> > on all public and protected methods which hopefully will make it slighly
> > easier to get on the train for those interested in helping out with Egit/Jgit.
> >
> > Disabling the else-warning is probably fairly uncontroversial. Disabling some
> > warning about boxing/unboxing of integers might be as might be requiring
> > javadoc comments.
> >
> >
> Hi Robin,
>
> [2, 3, 5 and 6] - looks fine to me.
Thanks for looking.
> [1] - What about something like "nothing to be done here" and/or
> "implementing interface method"?
"Empty" is a marker that the block is *intentionally* empty, which
is the point here.
> [4] - Some typos:
Thanks
-- robin
prev parent reply other threads:[~2008-02-05 22:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-05 0:15 [EGIT PATCH Series] Cleanups and javadocs Robin Rosenberg
2008-02-05 0:15 ` [EGIT PATCH 1/6] Comment some empty blocks that should be empty Robin Rosenberg
2008-02-05 0:15 ` [EGIT PATCH 2/6] Cleanup unboxing/boxing Robin Rosenberg
2008-02-05 0:15 ` [EGIT PATCH 3/6] Do not require javadoc in egit.core test project Robin Rosenberg
2008-02-05 0:15 ` [EGIT PATCH 4/6] Javadoc update for Egit Robin Rosenberg
2008-02-05 0:15 ` [EGIT PATCH 5/6] Drop unused GitBlobStorage class Robin Rosenberg
2008-02-05 0:15 ` [EGIT PATCH 6/6] Tighten requirements on javadoc Robin Rosenberg
2008-02-06 7:06 ` [EGIT PATCH 2/6] Cleanup unboxing/boxing Shawn O. Pearce
2008-02-06 20:14 ` [EGIT PATCH 1/2] Use Boolean.valueOf instead of new Boolean Robin Rosenberg
2008-02-06 20:15 ` [EGIT PATCH 2/2] Use Integer.valueOf instead of new Integer Robin Rosenberg
2008-02-08 2:52 ` Roger C. Soares
2008-02-05 15:09 ` [EGIT PATCH Series] Cleanups and javadocs Roger C. Soares
2008-02-05 21:47 ` Robin Rosenberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200802052247.47744.robin.rosenberg@dewire.com \
--to=robin.rosenberg@dewire.com \
--cc=dwatson@mimvista.com \
--cc=git@vger.kernel.org \
--cc=rogersoares@intelinet.com.br \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).