From: Jakub Narebski <jnareb@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Florian La Roche <laroche@redhat.com>
Subject: Re: [PATCH/RFC] gitweb: Make feed entries point to commitdiff view
Date: Wed, 6 Feb 2008 22:22:37 +0100 [thread overview]
Message-ID: <200802062222.38691.jnareb@gmail.com> (raw)
In-Reply-To: <7vd4r9vmnd.fsf@gitster.siamese.dyndns.org>
Dnia środa 6. lutego 2008 21:46, Junio C Hamano napisał:
> Jakub Narebski <jnareb@gmail.com> writes:
>
> > I think that with the improved commit message the reason for this
> > change is more obvious, and it is a go.
>
> Thanks. Looks good.
Errr... in the commit message
>> First, feed entries have whatchanged-like list of files which were
>> modified in a commit, so 'commitdiff' view more naturally reflects
>> feed entry (in more naturally alternate / extended version of a feed
>> item). Second, this way the patches are shown directly and code review
>> is done more easily via watching feeds.
"... (in more naturally ..." should be "... (is more naturally ...".
Unfortunately this kind of errors are hard to catch (and spellchecker
would not help any)
--
Jakub Narebski
Poland
prev parent reply other threads:[~2008-02-06 21:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-03 11:38 [PATCH/RFC] gitweb: Make feed entries point to commitdiff view Jakub Narebski
2008-02-06 20:46 ` Junio C Hamano
2008-02-06 21:22 ` Jakub Narebski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200802062222.38691.jnareb@gmail.com \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=laroche@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).