git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Narebski <jnareb@gmail.com>
To: "Stephen Sinclair" <radarsat1@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: command prompt script for current branch
Date: Wed, 6 Feb 2008 23:56:41 +0100	[thread overview]
Message-ID: <200802062356.41548.jnareb@gmail.com> (raw)
In-Reply-To: <9b3e2dc20802061413v5dbe349axe43a4af263e39878@mail.gmail.com>

On Wed, 6 Feb 2008, Stephen Sinclair wrote:

Please provide attribution (who write what) when quoting, like
below:

> Jakub Narebski wrote:
>> "Stephen Sinclair" <radarsat1@gmail.com> writes:

>>> Attached is a script I quickly wrote up yesterday.  Sometimes I've
>>> found I started working only to realize I was on the wrong branch.
>>> (Now that I'm accustomed to working with git, I make many small
>>> branches, so it happens.)
>>
>> First, it is much better to put such script inline, in the body of
>> your email.  This makes commenting about script body much easier.
>> And if you have to attach it, for example because your mailer mangles
>> whitespace (which is not the case here), make sure that attachement
>> uses "text/plain", and if possible "inline" disposition, to better
>> _view_ the code without need to save it to temporary file.
>>
>> I would take an exeption and comment on your code, even though you
>> make it hard to do so.
> 
> Thank you.  Since there's already a solution for this in contrib,
> (didn't see it, sorry), I'll just take your recommendations on coding
> style for any future stuff I do.

First, the code in contrib doesn't do all your code did. It doesn't
show if workarea is "dirty" (although I'm not sure if this is very
useful), nor does it show number of commits since or to mainline
(origin) version, although with working on (with) feature/topic
branches which does not have corresponding remote tracking branch
it seems not useful.

On the other hand code in _git_ps1 (taken from one of the "git prompt"
posts floating on git mailing list, and available in archives, together
with /usr/share/stgit/contrib/stgbashprompt.sh from StGit, Quilt-like
patch management layer on top of Git) shows also name of repository
and path in repository, and also if the branch is managed by StGit.


Second, I think you have learned something. Both on rules regarding
discussion, netiquette and sending contributions on this mailing list,
and about how to write scripts for/around git.  (At least I hope so).

-- 
Jakub Narebski
Poland

      reply	other threads:[~2008-02-06 22:57 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-06 19:52 command prompt script for current branch Stephen Sinclair
2008-02-06 20:42 ` Junio C Hamano
2008-02-06 22:14   ` [PATCH (repost)] Improve bash prompt to detect merge / rebase in progress Robin Rosenberg
2008-02-06 22:23     ` Robin Rosenberg
2008-02-06 22:31     ` Junio C Hamano
2008-02-07  0:23       ` Robin Rosenberg
2008-02-07  6:34         ` Shawn O. Pearce
2008-02-08 11:26           ` Steffen Prohaska
2008-02-08 12:25             ` Johannes Schindelin
2008-02-08 13:12               ` Steffen Prohaska
2008-02-08 14:06                 ` [PATCH/RFC] Make git-completion.bash a first-class citizen Johannes Schindelin
2008-02-06 23:21     ` [PATCH (repost)] Improve bash prompt to detect merge / rebase in progress Jakub Narebski
2008-02-06 23:44       ` Mike Hommey
2008-02-06 21:09 ` command prompt script for current branch Jakub Narebski
2008-02-06 22:13   ` Stephen Sinclair
2008-02-06 22:56     ` Jakub Narebski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200802062356.41548.jnareb@gmail.com \
    --to=jnareb@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=radarsat1@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).