From mboxrd@z Thu Jan 1 00:00:00 1970 From: "H.Merijn Brand" Subject: read_branches_file () Date: Fri, 8 Feb 2008 16:50:08 +0100 Message-ID: <20080208165008.52630d36@pc09.procura.nl> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Fri Feb 08 16:51:21 2008 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1JNVVI-0006kG-2a for gcvg-git-2@gmane.org; Fri, 08 Feb 2008 16:51:04 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757878AbYBHPuQ (ORCPT ); Fri, 8 Feb 2008 10:50:16 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757506AbYBHPuQ (ORCPT ); Fri, 8 Feb 2008 10:50:16 -0500 Received: from smtp-vbr1.xs4all.nl ([194.109.24.21]:1049 "EHLO smtp-vbr1.xs4all.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757265AbYBHPuO (ORCPT ); Fri, 8 Feb 2008 10:50:14 -0500 Received: from pc09.procura.nl (procura.xs4all.nl [82.95.216.29]) (authenticated bits=0) by smtp-vbr1.xs4all.nl (8.13.8/8.13.8) with ESMTP id m18Fo8b5013559 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Fri, 8 Feb 2008 16:50:13 +0100 (CET) (envelope-from h.m.brand@xs4all.nl) X-Mailer: Claws Mail 3.2.0cvs74 (GTK+ 2.10.6; x86_64-unknown-linux-gnu) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwEAIAAACI8LKTAAAACXBIWXMAAABIAAAASABGyWs+AAAC JElEQVRo3u2aMY4CMQxFczZ6RItEzRm4DBINDbRUSPRInIRbsNK6+dJfezN4kokn48IaCSjysL8d e9Knoj2fr9f9/gllqQ6U9/vxWK3EdwdIEGjRIVCu18NhuxUfK46SH81+fzrdbuKPx/P5ctHQdAdI TKAgpvV6s9ntBEfXEYSGgMQzIHnuFBBjkshCNJ2KtJZ04hHNAugP8bZr3NIHhbcF0AKoK0CoaHXU LUWBIs1n+jV+Fl8CVqOApEXAwyMO/DSR4XVntoAYDR7eBjQupuYAYTMph8Rj21D4m7MChN02tpqs NSnb/KqU2oHCXu5xDCgflj/RAgBiKBIXnICzAsSjWBsTz5K4/HeXYvb8yK5lY3VGEwPi2aONKT+5 AlcxrTPOwcTiraGRChgMEKJh0bVVifGVTq6qgBiNVl8QE29EsK6VE+YJAOG2wz5AvsqUS6uqgHCA n4NGvBYpnJ64Jgg27sCtxtBk1CJIA4S/GhdWKh07QxUB48jWGhZ4jKamRRr/T8/M0AaEyctry6YB 4dTGj9iWZNs3DahES5kPCJOu0RQbF/fQOBprsB9gaO9JtPDzII9U5ySXX7AnuIt91y54AAW7rPpT LCe5gt3F+CLqr2UarGB3MXvMylWGq4+9RCx3TW1oJq1t3HPQlFs6N1fFNEB4s8dn7Ne7ACSm7TPQ I5quAWmw6qBpulHM33B0Csge4Nd8JTTYG2b1XyRe3lH8x34ABJ6aePuQ2N4AAAAASUVORK5CYII= X-Virus-Scanned: by XS4ALL Virus Scanner Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: I'm (again) trying to port git-1.5.4 to HP-UX, and I've already got rather far, but I'm hitting some stuff I cannot explain. t5405-send-pack-rewind.sh fails the 'git fetch .. master:master' part in the setup, as deep down, read_branches_file () is called with in remote the name "..". The file that it tries to open using git_path () is ".git/branches/.." That is weird. That is not a file, but a dir. "../.git/branches" would be more logical, but whatever. HP-UX 11.00 will gladly return a valid FILE * for opening a directory with fopen (), which, when read, will return anything but what is expected. So, maybe read_branches_file () should be protected against opening anything but files. Maybe with some stat () and S_ISREG ()'s. Or has something gone wrong earlier on? In my case, the returned url is 'l', which cannot be opened: fatal: 'l': unable to chdir or not a git archive fatal: The remote end hung up unexpectedly which is cast from upload-pack.c:main () -- H.Merijn Brand Amsterdam Perl Mongers (http://amsterdam.pm.org/) using & porting perl 5.6.2, 5.8.x, 5.10.x on HP-UX 10.20, 11.00, 11.11, & 11.23, SuSE 10.1 & 10.2, AIX 5.2, and Cygwin. http://qa.perl.org http://mirrors.develooper.com/hpux/ http://www.test-smoke.org http://www.goldmark.org/jeff/stupid-disclaimers/