From: Michele Ballabio <barra_cuda@katamail.com>
To: git@vger.kernel.org
Cc: Miklos Vajna <vmiklos@frugalware.org>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] setup.c: guard config parser from value=NULL
Date: Fri, 8 Feb 2008 17:34:24 +0100 [thread overview]
Message-ID: <200802081734.24967.barra_cuda@katamail.com> (raw)
In-Reply-To: <20080208142702.GY25954@genesis.frugalware.org>
On Friday 08 February 2008, Miklos Vajna wrote:
> diff --git a/setup.c b/setup.c
> index adede16..361825f 100644
> --- a/setup.c
> +++ b/setup.c
> @@ -346,13 +346,13 @@ int git_config_perm(const char *var, const char *value)
> {
> if (value) {
^^^^^
value is already checked here. No need to check further.
> int i;
> - if (!strcmp(value, "umask"))
> + if (value && !strcmp(value, "umask"))
> return PERM_UMASK;
> - if (!strcmp(value, "group"))
> + if (value && !strcmp(value, "group"))
> return PERM_GROUP;
> - if (!strcmp(value, "all") ||
> + if (value && (!strcmp(value, "all") ||
> !strcmp(value, "world") ||
> - !strcmp(value, "everybody"))
> + !strcmp(value, "everybody")))
> return PERM_EVERYBODY;
> i = atoi(value);
> if (i > 1)
next prev parent reply other threads:[~2008-02-08 16:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-08 6:43 [Janitors] value could be NULL in config parser Junio C Hamano
2008-02-08 14:26 ` [PATCH] archive-tar.c: guard config parser from value=NULL Miklos Vajna
2008-02-08 14:26 ` [PATCH] builtin-gc.c: " Miklos Vajna
2008-02-08 14:26 ` [PATCH] remote.c: " Miklos Vajna
2008-02-08 16:34 ` Michele Ballabio
2008-02-08 14:27 ` [PATCH] setup.c: " Miklos Vajna
2008-02-08 16:34 ` Michele Ballabio [this message]
2008-02-08 21:29 ` Miklos Vajna
2008-02-08 17:07 ` [Janitors] value could be NULL in config parser Govind Salinas
2008-02-09 1:20 ` Govind Salinas
2008-02-09 5:41 ` Christian Couder
2008-02-09 6:04 ` Junio C Hamano
2008-02-09 10:18 ` Christian Couder
2008-02-09 13:15 ` Christian Couder
2008-02-09 20:11 ` Govind Salinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200802081734.24967.barra_cuda@katamail.com \
--to=barra_cuda@katamail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=vmiklos@frugalware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).