From: Mike Hommey <mh@glandium.org>
To: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH] Work around curl-gnutls not liking to be reinitialized
Date: Fri, 8 Feb 2008 22:31:48 +0100 [thread overview]
Message-ID: <20080208213148.GA2823@glandium.org> (raw)
In-Reply-To: <1202501335-28205-1-git-send-email-mh@glandium.org>
> In the end, it was a bit of git's fault, but either curl or gnutls is the
> actual culprit. I've not looked into either code to find out who's
> responsible, but a very simplified testcase is as follows:
>
> #include <curl/curl.h>
> #include <curl/easy.h>
>
> int main(void) {
> CURL *easy = curl_easy_init();
> curl_easy_setopt(easy, CURLOPT_VERBOSE, 1);
> curl_easy_setopt(easy, CURLOPT_URL, "https://www.verisign.com/");
> curl_easy_perform(easy);
> curl_global_cleanup();
> easy = curl_easy_init();
> curl_easy_setopt(easy, CURLOPT_VERBOSE, 1);
> curl_easy_setopt(easy, CURLOPT_URL, "https://www.verisign.com/");
> curl_easy_perform(easy);
> }
>
> (build with gcc -o test test.c -lcurl)
> (note curl_easy_init does curl_global_init behind the curtains, even the
> second time. You can convince yourself by adding
> curl_global_init(CURL_GLOBAL_ALL);)
And the winner is... curl !
The bug was introduced in this commit:
http://cool.haxx.se/cvs.cgi/curl/lib/gtls.c.diff?r1=1.26&r2=1.27
Note how gtls_inited is not set back to FALSE in cleanup.
This ended up released in 7.16.3. I'm filing a bug.
Mike
next prev parent reply other threads:[~2008-02-08 21:32 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-04 18:25 git-fetch in 1.5.4 fails versus 1.5.3.8 Anand Kumria
2008-02-05 5:07 ` Jeff King
2008-02-05 15:01 ` Jari Aalto
2008-02-06 21:56 ` Anand Kumria
2008-02-07 4:23 ` Jeff King
2008-02-07 6:37 ` Mike Hommey
2008-02-07 10:15 ` Anand Kumria
2008-02-07 11:06 ` Jeff King
2008-02-07 12:10 ` Mike Hommey
2008-02-07 12:28 ` Jeff King
2008-02-07 22:02 ` Mike Hommey
2008-02-08 0:32 ` Jeff King
2008-02-08 7:18 ` Mike Hommey
2008-02-08 7:34 ` Mike Hommey
2008-02-08 20:08 ` [PATCH] Work around curl-gnutls not liking to be reinitialized Mike Hommey
2008-02-08 21:31 ` Mike Hommey [this message]
2008-02-08 21:46 ` Junio C Hamano
2008-02-08 21:51 ` Mike Hommey
2008-02-08 22:09 ` Mike Hommey
2008-02-08 22:22 ` [PATCH v2] " Mike Hommey
2008-02-08 22:51 ` Johannes Schindelin
2008-02-08 23:08 ` [PATCH] " Mike Hommey
2008-02-08 23:14 ` Mike Hommey
2008-02-09 9:41 ` [PATCH v4] " Mike Hommey
2008-02-09 21:51 ` Daniel Stenberg
2008-02-09 9:44 ` [PATCH v2] " Florian Weimer
2008-02-09 10:43 ` Mike Hommey
2008-02-08 21:53 ` [PATCH] " Johannes Schindelin
2008-02-08 22:01 ` Mike Hommey
2008-02-09 2:28 ` Jeff King
2008-02-07 14:23 ` git-fetch in 1.5.4 fails versus 1.5.3.8 Frank Lichtenheld
2008-02-07 18:42 ` Linus Torvalds
2008-02-07 20:14 ` Frank Lichtenheld
2008-02-07 20:54 ` Linus Torvalds
2008-02-07 21:36 ` Anand Kumria
2008-02-07 20:40 ` Jeff King
2008-02-07 21:01 ` Linus Torvalds
2008-02-07 21:47 ` Martin Langhoff
2008-02-07 21:53 ` Dmitry Potapov
2008-02-07 22:46 ` Jeff King
2008-02-07 22:40 ` Jeff King
2008-02-07 23:23 ` Dmitry Potapov
2008-02-08 2:43 ` Anand Kumria
2008-02-08 13:27 ` Dmitry Potapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080208213148.GA2823@glandium.org \
--to=mh@glandium.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).