From: Christian Couder <chriscool@tuxfamily.org>
To: "Govind Salinas" <blix@sophiasuchtig.com>
Cc: "Git Mailing List" <git@vger.kernel.org>,
"Junio C Hamano" <gitster@pobox.com>
Subject: Re: [PATCH] http.c: guard config parser from value=NULL
Date: Sat, 9 Feb 2008 18:46:26 +0100 [thread overview]
Message-ID: <200802091846.26708.chriscool@tuxfamily.org> (raw)
In-Reply-To: <5d46db230802081639n78aab3b2s1e83ab9c4afc6a38@mail.gmail.com>
Le samedi 9 février 2008, Govind Salinas a écrit :
> Signed-off-by: Govind Salinas <blix@sophiasuchtig.com>
> ---
> http.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/http.c b/http.c
> index d2c11ae..0a2c1c8 100644
> --- a/http.c
> +++ b/http.c
> @@ -92,6 +92,9 @@ static void process_curl_messages(void)
>
> static int http_options(const char *var, const char *value)
> {
> + if (!value)
> + return git_default_config(var, value);
> +
> if (!strcmp("http.sslverify", var)) {
> if (curl_ssl_verify == -1) {
> curl_ssl_verify = git_config_bool(var, value);
After a very quick look at this, it seems that no change is needed here
because 'git_config_bool' handles a NULL value correctly. Some changes may
be needed below though.
Thanks,
Christian.
next prev parent reply other threads:[~2008-02-09 17:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-09 0:39 [PATCH] http.c: guard config parser from value=NULL Govind Salinas
2008-02-09 17:46 ` Christian Couder [this message]
2008-02-09 21:09 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200802091846.26708.chriscool@tuxfamily.org \
--to=chriscool@tuxfamily.org \
--cc=blix@sophiasuchtig.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).